mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.
Date Mon, 18 Mar 2019 15:16:56 GMT
asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between
Type and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326#discussion_r266492065
 
 

 ##########
 File path: src/common/protobuf_utils.hpp
 ##########
 @@ -64,6 +64,63 @@ struct Slave;
 
 namespace protobuf {
 
+//
+// A "protobuf union" is a protobuf message
+// which has an enum named "Type" defined in its scope,
+// a required field named "type" of a "Type" type
+// and a field corresponding to each member of the "Type" enum.
+//
+// A valid "protobuf union" should satisfy the following requirements.
+// 1. A member of the Type enum with a number (not index!) of 0,
+//    if there is any, should be named "UNKNOWN".
+// 2. For each other member of the Type enum there should be an optional field
+//    in the message with an exactly matching name in lowercase.
+// 3. The fields that correspond to members of the Type enum other than
+//    message.type(), should not be set.
+//
+// NOTE: If possible, oneof should be used in the new messages instead
+// of the "protobuf union".
+//
+class UnionValidatorHelper
+{
+public:
+  UnionValidatorHelper(
+      const google::protobuf::Descriptor*,
+      const google::protobuf::EnumDescriptor*);
+
+  Option<Error> Validate(
+      const int messageTypeNumber, const google::protobuf::Message&) const;
+
+private:
+  std::vector<std::pair<int, const google::protobuf::FieldDescriptor*>>
+    UnionFieldDescriptors;
+  const google::protobuf::EnumDescriptor* TypeDescriptor;
+};
+
+
+template <class Message>
+class UnionValidator
+{
+public:
+  static Option<Error> Validate(const Message& message)
+  {
+    static const UnionValidatorHelper helper(
 
 Review comment:
   Exactly. We do not need this class at all. Moved and renamed, as you suggested.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message