mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] lava commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.
Date Tue, 12 Mar 2019 11:12:04 GMT
lava commented on a change in pull request #326: MESOS-6874: Validate the match between Type
and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326#discussion_r264624869
 
 

 ##########
 File path: include/mesos/mesos.proto
 ##########
 @@ -3328,6 +3328,9 @@ message TTYInfo {
  */
 message ContainerInfo {
   // All container implementation types.
+  // For each type there should be a field in the ContainerInfo itself
+  // with exactly matching name in the lowercase.
 
 Review comment:
   We looked at `oneof` while writing the patches, but we cannot use it here because it breaks
backwards compatibility.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message