mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] lava commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.
Date Tue, 12 Mar 2019 11:12:04 GMT
lava commented on a change in pull request #326: MESOS-6874: Validate the match between Type
and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326#discussion_r264623839
 
 

 ##########
 File path: src/tests/containerizer/composing_containerizer_tests.cpp
 ##########
 @@ -57,6 +57,32 @@ namespace tests {
 
 class ComposingContainerizerTest : public MesosTest {};
 
+TEST_F(ComposingContainerizerTest, FailsOnContainerInfoTypeMismatch)
 
 Review comment:
   I'm not sure that I understand your comment - the validation acts on the protobuf message,
so the value of the `--containerizers` flag should not make any difference?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message