mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.
Date Mon, 11 Mar 2019 19:19:09 GMT
kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between
Type and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326#discussion_r264389356
 
 

 ##########
 File path: src/tests/containerizer/composing_containerizer_tests.cpp
 ##########
 @@ -57,6 +57,32 @@ namespace tests {
 
 class ComposingContainerizerTest : public MesosTest {};
 
+TEST_F(ComposingContainerizerTest, FailsOnContainerInfoTypeMismatch)
 
 Review comment:
   It should be possible to have the same validation error when only using a single containerizer.
 
   
   i.e. When the `DockerInfo` is filled in with a `Mesos` Type, that is treated like an empty
`MesosInfo` instead of an error.  This is true even if the Mesos containerizer is the only
active containerizer.
   
   As such, we'd ideally have a parameterized test for each of the three possible cases (`mesos`,
`mesos,docker`, and `docker`).  Here's a test that is parameterized by the `--containerizers`
agent flag:
   https://github.com/apache/mesos/blob/master/src/tests/default_executor_tests.cpp#L111-L124

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message