mesos-reviews mailing list archives: February 2019

Site index · List index
Message list« Previous · 1 · 2 · 3 · 4 · 5 · Next »Thread · Author · Date
Re: Review Request 69313: Enabled parallel test runner to cmake build.
Mesos Reviewbot   Re: Review Request 69313: Enabled parallel test runner to cmake build. Fri, 22 Feb, 09:25
Re: Review Request 67185: Added request_protobuf to mesos.http.
Mesos Reviewbot   Re: Review Request 67185: Added request_protobuf to mesos.http. Fri, 22 Feb, 13:33
Re: Review Request 68654: Enabled isort for src/python/lib.
Mesos Reviewbot   Re: Review Request 68654: Enabled isort for src/python/lib. Fri, 22 Feb, 16:49
Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.
Mesos Reviewbot   Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings. Fri, 22 Feb, 19:18
Re: Review Request 68785: Added jsonschema.py for managing json-based configs.
Mesos Reviewbot   Re: Review Request 68785: Added jsonschema.py for managing json-based configs. Fri, 22 Feb, 21:50
Re: Review Request 69342: Added an agent flag `--volume_gid_range`.
Gilbert Song   Re: Review Request 69342: Added an agent flag `--volume_gid_range`. Fri, 22 Feb, 22:38
Qian Zhang   Re: Review Request 69342: Added an agent flag `--volume_gid_range`. Tue, 26 Feb, 02:50
Gilbert Song     Re: Review Request 69342: Added an agent flag `--volume_gid_range`. Thu, 28 Feb, 00:51
Re: Review Request 69551: Renamed `Metrics()` function in test utils.
Mesos Reviewbot   Re: Review Request 69551: Renamed `Metrics()` function in test utils. Fri, 22 Feb, 22:53
Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.
Mesos Reviewbot   Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script. Fri, 22 Feb, 23:53
Re: Review Request 69701: Improved debuggability of `verify-reviews.py`.
Mesos Reviewbot   Re: Review Request 69701: Improved debuggability of `verify-reviews.py`. Sat, 23 Feb, 00:46
Gastón Kleiman Review Request 70044: Moved status update streams of operations on agent's default resources. Sat, 23 Feb, 01:33
Gastón Kleiman   Re: Review Request 70044: Moved status update streams of operations on agent's default resources. Sat, 23 Feb, 01:34
Mesos Reviewbot Windows     Re: Review Request 70044: Moved status update streams of operations on agent's default resources. Sat, 23 Feb, 04:48
Mesos Reviewbot     Re: Review Request 70044: Moved status update streams of operations on agent's default resources. Sat, 23 Feb, 15:10
Greg Mann     Re: Review Request 70044: Moved status update streams of operations on agent's default resources. Tue, 26 Feb, 18:46
Gastón Kleiman       Re: Review Request 70044: Moved status update streams of operations on agent's default resources. Tue, 26 Feb, 18:51
Gastón Kleiman     Re: Review Request 70044: Moved status update streams of operations on agent's default resources. Tue, 26 Feb, 19:01
Mesos Reviewbot       Re: Review Request 70044: Moved status update streams of operations on agent's default resources. Tue, 26 Feb, 20:49
Mesos Reviewbot       Re: Review Request 70044: Moved status update streams of operations on agent's default resources. Tue, 26 Feb, 20:57
Greg Mann       Re: Review Request 70044: Moved status update streams of operations on agent's default resources. Tue, 26 Feb, 23:03
Re: Review Request 69675: Added volume gid manager.
Gilbert Song   Re: Review Request 69675: Added volume gid manager. Sat, 23 Feb, 07:02
Qian Zhang     Re: Review Request 69675: Added volume gid manager. Mon, 25 Feb, 08:04
Benjamin Bannier   Re: Review Request 69675: Added volume gid manager. Mon, 25 Feb, 14:15
Qian Zhang     Re: Review Request 69675: Added volume gid manager. Tue, 26 Feb, 08:46
Gilbert Song   Re: Review Request 69675: Added volume gid manager. Mon, 25 Feb, 19:42
Qian Zhang   Re: Review Request 69675: Added volume gid manager. Wed, 27 Feb, 14:45
Gilbert Song     Re: Review Request 69675: Added volume gid manager. Thu, 28 Feb, 00:50
Re: Review Request 69553: Changed the definition of `uid_t` and `gid_t` to UNIT for Windows.
Gilbert Song   Re: Review Request 69553: Changed the definition of `uid_t` and `gid_t` to UNIT for Windows. Sat, 23 Feb, 07:13
Re: Review Request 69479: Added the flag `--task_supplementary_groups` to command executor.
Gilbert Song   Re: Review Request 69479: Added the flag `--task_supplementary_groups` to command executor. Sat, 23 Feb, 07:14
Benjamin Bannier Review Request 70045: Skipped tests when verifying `master` as part of review verification. Sat, 23 Feb, 20:18
Mesos Reviewbot Windows   Re: Review Request 70045: Skipped tests when verifying `master` as part of review verification. Sat, 23 Feb, 21:27
Mesos Reviewbot   Re: Review Request 70045: Skipped tests when verifying `master` as part of review verification. Sat, 23 Feb, 22:19
Vinod Kone   Re: Review Request 70045: Skipped tests when verifying `master` as part of review verification. Sat, 23 Feb, 22:55
Benjamin Bannier     Re: Review Request 70045: Skipped tests when verifying `master` as part of review verification. Sun, 24 Feb, 07:55
Benjamin Bannier   Re: Review Request 70045: Skipped tests when verifying `master` as part of review verification. Sun, 24 Feb, 22:03
Till Toenshoff via Review Board     Re: Review Request 70045: Skipped tests when verifying `master` as part of review verification. Sun, 24 Feb, 22:15
Mesos Reviewbot Windows     Re: Review Request 70045: Skipped tests when verifying `master` as part of review verification. Sun, 24 Feb, 23:48
Benjamin Bannier Review Request 70046: Prevented closing invalid file descriptors. Sat, 23 Feb, 20:41
Mesos Reviewbot Windows   Re: Review Request 70046: Prevented closing invalid file descriptors. Sat, 23 Feb, 23:04
Mesos Reviewbot   Re: Review Request 70046: Prevented closing invalid file descriptors. Sun, 24 Feb, 00:40
Benjamin Mahler   Re: Review Request 70046: Prevented closing invalid file descriptors. Mon, 25 Feb, 17:06
Benjamin Bannier     Re: Review Request 70046: Prevented closing invalid file descriptors. Mon, 25 Feb, 21:19
Benjamin Bannier   Re: Review Request 70046: Prevented closing invalid file descriptors. Mon, 25 Feb, 21:19
Benjamin Mahler     Re: Review Request 70046: Prevented closing invalid file descriptors. Mon, 25 Feb, 21:55
Jason Lai Review Request 70048: Documented the new `--host_path_volume_force_creation` agent option. Mon, 25 Feb, 01:19
Gilbert Song   Re: Review Request 70048: Documented the new `--host_path_volume_force_creation` agent option. Mon, 25 Feb, 02:25
Mesos Reviewbot Windows   Re: Review Request 70048: Documented the new `--host_path_volume_force_creation` agent option. Mon, 25 Feb, 02:57
Mesos Reviewbot   Re: Review Request 70048: Documented the new `--host_path_volume_force_creation` agent option. Mon, 25 Feb, 03:54
Mesos Reviewbot   Re: Review Request 70048: Documented the new `--host_path_volume_force_creation` agent option. Mon, 25 Feb, 03:55
Till Toenshoff via Review Board Review Request 70047: Updated build specific artefact generation. Mon, 25 Feb, 01:32
Till Toenshoff via Review Board   Re: Review Request 70047: Updated build specific artefact generation. Mon, 25 Feb, 02:35
Till Toenshoff via Review Board     Re: Review Request 70047: Updated build specific artefact generation. Tue, 26 Feb, 02:18
Till Toenshoff via Review Board       Re: Review Request 70047: Updated build specific artefact generation. Tue, 26 Feb, 02:20
Till Toenshoff via Review Board         Re: Review Request 70047: Updated build specific artefact generation. Tue, 26 Feb, 11:05
Joseph Wu           Re: Review Request 70047: Updated build specific artefact generation. Tue, 26 Feb, 20:22
Till Toenshoff via Review Board             Re: Review Request 70047: Updated build specific artefact generation. Thu, 28 Feb, 20:03
Benjamin Bannier           Re: Review Request 70047: Updated build specific artefact generation. Fri, 01 Mar, 00:02
Till Toenshoff via Review Board Review Request 70049: Assured a set USER within RPM build. Mon, 25 Feb, 01:56
Till Toenshoff via Review Board   Re: Review Request 70049: Assured a set USER within RPM build. Mon, 25 Feb, 02:31
Mesos Reviewbot Windows     Re: Review Request 70049: Assured a set USER within RPM build. Mon, 25 Feb, 04:34
Mesos Reviewbot     Re: Review Request 70049: Assured a set USER within RPM build. Mon, 25 Feb, 06:11
Mesos Reviewbot     Re: Review Request 70049: Assured a set USER within RPM build. Mon, 25 Feb, 06:20
Benjamin Bannier     Re: Review Request 70049: Assured a set USER within RPM build. Thu, 28 Feb, 20:52
Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.
Gilbert Song   Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume. Mon, 25 Feb, 03:33
Qian Zhang     Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume. Mon, 25 Feb, 08:17
Benjamin Bannier   Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume. Mon, 25 Feb, 14:15
Qian Zhang     Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume. Tue, 26 Feb, 08:51
Gilbert Song   Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume. Mon, 25 Feb, 19:50
Qian Zhang   Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume. Tue, 26 Feb, 02:54
Qian Zhang     Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume. Wed, 27 Feb, 14:46
Gilbert Song       Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume. Thu, 28 Feb, 00:51
Re: Review Request 69478: Added `task_supplementary_groups` into `ContainerLaunchInfo`.
Gilbert Song   Re: Review Request 69478: Added `task_supplementary_groups` into `ContainerLaunchInfo`. Mon, 25 Feb, 03:33
Re: Review Request 69544: Made non-root containers can access shared persistent volume.
Gilbert Song   Re: Review Request 69544: Made non-root containers can access shared persistent volume. Mon, 25 Feb, 03:43
Qian Zhang     Re: Review Request 69544: Made non-root containers can access shared persistent volume. Mon, 25 Feb, 14:24
Gilbert Song   Re: Review Request 69544: Made non-root containers can access shared persistent volume. Mon, 25 Feb, 20:00
Qian Zhang   Re: Review Request 69544: Made non-root containers can access shared persistent volume. Tue, 26 Feb, 03:01
Qian Zhang     Re: Review Request 69544: Made non-root containers can access shared persistent volume. Wed, 27 Feb, 14:47
Gilbert Song       Re: Review Request 69544: Made non-root containers can access shared persistent volume. Thu, 28 Feb, 01:09
Re: Review Request 69481: Deallocated the shared persistent volume's gid when it is removed.
Gilbert Song   Re: Review Request 69481: Deallocated the shared persistent volume's gid when it is removed. Mon, 25 Feb, 03:43
Re: Review Request 69676: Implemented recovery for volume gid manager.
Gilbert Song   Re: Review Request 69676: Implemented recovery for volume gid manager. Mon, 25 Feb, 03:43
Benjamin Bannier   Re: Review Request 69676: Implemented recovery for volume gid manager. Mon, 25 Feb, 14:15
Qian Zhang     Re: Review Request 69676: Implemented recovery for volume gid manager. Tue, 26 Feb, 08:52
Qian Zhang   Re: Review Request 69676: Implemented recovery for volume gid manager. Tue, 26 Feb, 03:02
Qian Zhang     Re: Review Request 69676: Implemented recovery for volume gid manager. Tue, 26 Feb, 15:17
Qian Zhang       Re: Review Request 69676: Implemented recovery for volume gid manager. Wed, 27 Feb, 14:57
Gilbert Song         Re: Review Request 69676: Implemented recovery for volume gid manager. Thu, 28 Feb, 01:24
Qian Zhang         Re: Review Request 69676: Implemented recovery for volume gid manager. Thu, 28 Feb, 03:06
Gilbert Song           Re: Review Request 69676: Implemented recovery for volume gid manager. Thu, 28 Feb, 06:17
Re: Review Request 67997: Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
Gilbert Song   Re: Review Request 67997: Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`. Mon, 25 Feb, 03:44
Qian Zhang   Re: Review Request 67997: Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`. Tue, 26 Feb, 03:03
Gilbert Song     Re: Review Request 67997: Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`. Thu, 28 Feb, 01:30
Re: Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`.
Gilbert Song   Re: Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`. Mon, 25 Feb, 03:44
Qian Zhang   Re: Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`. Tue, 26 Feb, 03:05
Gilbert Song     Re: Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`. Thu, 28 Feb, 01:31
Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.
Gilbert Song   Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`. Mon, 25 Feb, 03:44
Qian Zhang   Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`. Tue, 26 Feb, 03:06
Gilbert Song     Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`. Thu, 28 Feb, 01:35
Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.
Gilbert Song   Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`. Mon, 25 Feb, 03:44
Qian Zhang   Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`. Tue, 26 Feb, 03:07
Gilbert Song     Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`. Thu, 28 Feb, 01:35
Re: Review Request 69579: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxLocalPersistentVolume`.
Gilbert Song   Re: Review Request 69579: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxLocalPersistentVolume`. Mon, 25 Feb, 03:44
Qian Zhang   Re: Review Request 69579: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxLocalPersistentVolume`. Tue, 26 Feb, 03:08
Gilbert Song     Re: Review Request 69579: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxLocalPersistentVolume`. Thu, 28 Feb, 01:35
Re: Review Request 69613: Added tests for volume gid manager.
Gilbert Song   Re: Review Request 69613: Added tests for volume gid manager. Mon, 25 Feb, 03:44
Qian Zhang   Re: Review Request 69613: Added tests for volume gid manager. Tue, 26 Feb, 03:09
Gilbert Song     Re: Review Request 69613: Added tests for volume gid manager. Thu, 28 Feb, 01:36
Benjamin Bannier Review Request 70053: Used std::string as buffer instead of manually managed dynamic array. Mon, 25 Feb, 21:20
Benjamin Mahler   Re: Review Request 70053: Used std::string as buffer instead of manually managed dynamic array. Mon, 25 Feb, 22:05
Benjamin Bannier     Re: Review Request 70053: Used std::string as buffer instead of manually managed dynamic array. Mon, 25 Feb, 22:21
Benjamin Mahler     Re: Review Request 70053: Used std::string as buffer instead of manually managed dynamic array. Mon, 25 Feb, 23:47
Mesos Reviewbot   Re: Review Request 70053: Used std::string as buffer instead of manually managed dynamic array. Mon, 25 Feb, 23:47
Mesos Reviewbot   Re: Review Request 70053: Used std::string as buffer instead of manually managed dynamic array. Tue, 26 Feb, 01:16
Benjamin Mahler Review Request 70054: Added FrameworkInfo.offer_filters to multi-scheduler scalability docs. Mon, 25 Feb, 22:24
Mesos Reviewbot   Re: Review Request 70054: Added FrameworkInfo.offer_filters to multi-scheduler scalability docs. Tue, 26 Feb, 02:12
Mesos Reviewbot   Re: Review Request 70054: Added FrameworkInfo.offer_filters to multi-scheduler scalability docs. Tue, 26 Feb, 03:21
Meng Zhu   Re: Review Request 70054: Added FrameworkInfo.offer_filters to multi-scheduler scalability docs. Tue, 26 Feb, 03:50
Benjamin Mahler   Re: Review Request 70054: Added FrameworkInfo.offer_filters to multi-scheduler scalability docs. Tue, 26 Feb, 20:45
Vinod Kone Review Request 70055: Output Review Request URL in Reviewbot output. Mon, 25 Feb, 23:44
Till Toenshoff via Review Board   Re: Review Request 70055: Output Review Request URL in Reviewbot output. Mon, 25 Feb, 23:55
Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.
Mesos Reviewbot   Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer. Tue, 26 Feb, 21:33
Vinod Kone Review Request 70060: Updated ReviewBot to catch diff updates recursively up the chain. Tue, 26 Feb, 23:45
Mesos Reviewbot   Re: Review Request 70060: Updated ReviewBot to catch diff updates recursively up the chain. Wed, 27 Feb, 01:49
Mesos Reviewbot   Re: Review Request 70060: Updated ReviewBot to catch diff updates recursively up the chain. Wed, 27 Feb, 02:14
Benjamin Bannier   Re: Review Request 70060: Updated ReviewBot to catch diff updates recursively up the chain. Wed, 27 Feb, 12:02
Vinod Kone   Re: Review Request 70060: Updated ReviewBot to verify reviews by checking for updates recursively. Thu, 28 Feb, 18:53
Re: Review Request 67044: Renamed a method in the master metrics.
Mesos Reviewbot   Re: Review Request 67044: Renamed a method in the master metrics. Wed, 27 Feb, 00:10
Meng Zhu Review Request 70061: Added method `fromScalarResources` in `ResourceQuantities`. Wed, 27 Feb, 01:28
Benjamin Mahler   Re: Review Request 70061: Added method `fromScalarResources` in `ResourceQuantities`. Wed, 27 Feb, 16:28
Meng Zhu     Re: Review Request 70061: Added method `fromScalarResources` in `ResourceQuantities`. Thu, 28 Feb, 01:12
Meng Zhu Review Request 70062: Refactored and augmented `class ResourceQuantities`. Wed, 27 Feb, 01:29
Benjamin Mahler   Re: Review Request 70062: Refactored and augmented `class ResourceQuantities`. Wed, 27 Feb, 17:04
Meng Zhu     Re: Review Request 70062: Refactored and augmented `class ResourceQuantities`. Thu, 28 Feb, 01:19
Meng Zhu Review Request 70063: Added test for `ResourceQuantities` arithmetic operations. Wed, 27 Feb, 01:30
Mesos Reviewbot   Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations. Wed, 27 Feb, 04:09
Mesos Reviewbot   Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations. Wed, 27 Feb, 04:22
Benjamin Mahler   Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations. Wed, 27 Feb, 16:34
Meng Zhu     Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations. Thu, 28 Feb, 01:24
Mesos Reviewbot   Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations. Thu, 28 Feb, 03:39
Mesos Reviewbot   Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations. Thu, 28 Feb, 03:53
Re: Review Request 67761: Added a new registry field `minimum_capabilities`.
Joseph Wu   Re: Review Request 67761: Added a new registry field `minimum_capabilities`. Wed, 27 Feb, 01:47
Meng Zhu Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Wed, 27 Feb, 18:15
Benjamin Mahler   Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Wed, 27 Feb, 18:55
Benjamin Bannier   Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Wed, 27 Feb, 19:14
Meng Zhu     Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Thu, 28 Feb, 03:55
Mesos Reviewbot   Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Wed, 27 Feb, 20:50
Mesos Reviewbot   Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Wed, 27 Feb, 21:00
Mesos Reviewbot   Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Thu, 28 Feb, 06:25
Mesos Reviewbot   Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Thu, 28 Feb, 22:54
Mesos Reviewbot   Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Thu, 28 Feb, 22:57
Message list« Previous · 1 · 2 · 3 · 4 · 5 · Next »Thread · Author · Date
Box list
Feb 2020171
Jan 2020303
Dec 2019159
Nov 2019239
Oct 2019162
Sep 2019312
Aug 2019540
Jul 2019707
Jun 2019621
May 2019472
Apr 2019702
Mar 2019955
Feb 2019758
Jan 2019749
Dec 2018455
Nov 2018598
Oct 2018832
Sep 2018704
Aug 20181218
Jul 20181040
Jun 20181026
May 20181520
Apr 20181445
Mar 20181350
Feb 20181396
Jan 20181470
Dec 20171464
Nov 20171769
Oct 20171445
Sep 20171054
Aug 20171341
Jul 20171295
Jun 20171475
May 20171547
Apr 20171266
Mar 20172102
Feb 20171631
Jan 20171655
Dec 20161774
Nov 20162300
Oct 20162196
Sep 20162748
Aug 20162311
Jul 20163001
Jun 20163216
May 20162928
Apr 20163332
Mar 20164025
Feb 20162997
Jan 20163700
Dec 20152431
Nov 20152744
Oct 20152284
Sep 20152621
Aug 20152300
Jul 20152051
Jun 20152449
May 20151444
Apr 2015338