----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70011/ ----------------------------------------------------------- Review request for mesos, Gilbert Song, Greg Mann, and Joseph Wu. Bugs: MESOS-9564 https://issues.apache.org/jira/browse/MESOS-9564 Repository: mesos Description ------- This patch changes the mechanism of verifying application of custom logrotation options. Since we don't create logrotate config file in the container's sandbox on Linux, we can't use the previous approach where we tried to find the custom options in the generated `stdout.logrotate.conf`. Instead, we inject a script into custom options, which creates an empty file in the temporary directory on log rotation. Diffs ----- src/tests/container_logger_tests.cpp 6c6b3152d82a3c9825a0b4f1b5f8c9a065cb2927 Diff: https://reviews.apache.org/r/70011/diff/1/ Testing ------- internal CI Thanks, Andrei Budnik