From reviews-return-85425-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Feb 18 12:05:49 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BF7031889B for ; Mon, 18 Feb 2019 12:05:49 +0000 (UTC) Received: (qmail 50849 invoked by uid 500); 18 Feb 2019 12:05:49 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 50813 invoked by uid 500); 18 Feb 2019 12:05:49 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 50743 invoked by uid 99); 18 Feb 2019 12:05:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Feb 2019 12:05:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8B3F318564E; Mon, 18 Feb 2019 12:05:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.701 X-Spam-Level: X-Spam-Status: No, score=0.701 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id WO36CUSimc3S; Mon, 18 Feb 2019 12:05:47 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7C1C25FE1F; Mon, 18 Feb 2019 12:05:46 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D4CFFE00A9; Mon, 18 Feb 2019 12:05:45 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 8C9D3C403A7; Mon, 18 Feb 2019 12:05:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1410430688005307615==" MIME-Version: 1.0 Subject: Re: Review Request 70001: Fixed an inaccurate comment in agent code. From: Andrei Budnik To: Andrei Budnik Cc: Qian Zhang , mesos Date: Mon, 18 Feb 2019 12:05:45 -0000 Message-ID: <20190218120545.45096.76197@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Budnik X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/70001/ X-Sender: Andrei Budnik X-ReviewBoard-ShipIt: 1 References: <20190218081520.45095.63260@reviews-vm2.apache.org> In-Reply-To: <20190218081520.45095.63260@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Andrei Budnik X-ReviewRequest-Repository: mesos --===============1410430688005307615== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70001/#review212898 ----------------------------------------------------------- Ship it! Ship It! - Andrei Budnik On Feb. 18, 2019, 8:15 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70001/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2019, 8:15 a.m.) > > > Review request for mesos, Andrei Budnik and Gilbert Song. > > > Repository: mesos > > > Description > ------- > > Given that `state::checkpoint` is atomic, an empty file could occur > in case of slave host is hard rebooted after the file is created but > before the data is synced on disk rather than slave process died. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 7b8030a5573a822975a0ba1bfc72f50bcc7098ae > src/slave/state.cpp 92f777560cb9c85bfa239ba7847bb14b421fe0e7 > > > Diff: https://reviews.apache.org/r/70001/diff/1/ > > > Testing > ------- > > Not a functional change. > > > Thanks, > > Qian Zhang > > --===============1410430688005307615==--