| Meng Zhu |
Re: Review Request 69942: Added a test for MESOS-9554. |
Tue, 12 Feb, 18:46 |
| Meng Zhu |
Review Request 69981: Fixed a flaky test `MasterQuotaTest.RemoveSingleQuota`. |
Thu, 14 Feb, 00:27 |
| Meng Zhu |
Re: Review Request 69656: Fixed test `MesosContainerizerSlaveRecoveryTest.ResourceStatistics`. |
Thu, 14 Feb, 01:30 |
| Meng Zhu |
Re: Review Request 69989: Fixed an allocator crash during reservation tracking. |
Thu, 14 Feb, 21:57 |
| Meng Zhu |
Re: Review Request 69990: Added a regression test for MESOS-9555. |
Thu, 14 Feb, 22:01 |
| Meng Zhu |
Re: Review Request 69981: Fixed a flaky test `MasterQuotaTest.RemoveSingleQuota`. |
Fri, 15 Feb, 22:11 |
| Meng Zhu |
Re: Review Request 67762: Added minimum capability check during master recovery. |
Wed, 20 Feb, 18:46 |
| Meng Zhu |
Re: Review Request 70054: Added FrameworkInfo.offer_filters to multi-scheduler scalability docs. |
Tue, 26 Feb, 03:50 |
| Meng Zhu |
Review Request 70061: Added method `fromScalarResources` in `ResourceQuantities`. |
Wed, 27 Feb, 01:28 |
| Meng Zhu |
Review Request 70062: Refactored and augmented `class ResourceQuantities`. |
Wed, 27 Feb, 01:29 |
| Meng Zhu |
Review Request 70063: Added test for `ResourceQuantities` arithmetic operations. |
Wed, 27 Feb, 01:30 |
| Meng Zhu |
Review Request 70067: Added star operator for `Result`, `Try` and `Option`. |
Wed, 27 Feb, 18:15 |
| Meng Zhu |
Re: Review Request 70061: Added method `fromScalarResources` in `ResourceQuantities`. |
Thu, 28 Feb, 01:12 |
| Meng Zhu |
Re: Review Request 70062: Refactored and augmented `class ResourceQuantities`. |
Thu, 28 Feb, 01:19 |
| Meng Zhu |
Review Request 70069: Improved `ResourceQuantities` test's readability. |
Thu, 28 Feb, 01:21 |
| Meng Zhu |
Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations. |
Thu, 28 Feb, 01:24 |
| Meng Zhu |
Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. |
Thu, 28 Feb, 03:55 |
| Meng Zhu |
Review Request 70077: Added documentation regarding downgrading a Mesos cluster. |
Thu, 28 Feb, 21:56 |
| Meng Zhu |
Re: Review Request 67762: Added minimum capability check during master recovery. |
Thu, 28 Feb, 23:08 |
| Meng Zhu |
Re: Review Request 67762: Added minimum capability check during master recovery. |
Thu, 28 Feb, 23:09 |
| Mesos Reviewbot |
Re: Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations. |
Wed, 06 Feb, 02:04 |
| Mesos Reviewbot |
Re: Review Request 69891: Sent operation updates to schedulers when agents are removed. |
Tue, 12 Feb, 03:53 |
| Mesos Reviewbot |
Re: Review Request 69909: Tested unreachable task behavior on agent GC. |
Tue, 12 Feb, 08:32 |
| Mesos Reviewbot |
Re: Review Request 69931: Empty test commit. |
Tue, 12 Feb, 20:33 |
| Mesos Reviewbot |
Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources. |
Wed, 13 Feb, 04:46 |
| Mesos Reviewbot |
Re: Review Request 69969: Updated docs related to agent capabilities. |
Wed, 13 Feb, 09:46 |
| Mesos Reviewbot |
Re: Review Request 69971: Removed an outdated comment in SLRP. |
Wed, 13 Feb, 16:02 |
| Mesos Reviewbot |
Re: Review Request 69972: Skipped the container which has no checkpointed volumes during recovery. |
Wed, 13 Feb, 18:41 |
| Mesos Reviewbot |
Re: Review Request 69978: Added garbage collection of terminated operations status update streams. |
Thu, 14 Feb, 01:56 |
| Mesos Reviewbot |
Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources. |
Thu, 14 Feb, 04:35 |
| Mesos Reviewbot |
Re: Review Request 69980: Modified when master responds to operation status updates. |
Thu, 14 Feb, 07:03 |
| Mesos Reviewbot |
Re: Review Request 69981: Fixed a flaky test `MasterQuotaTest.RemoveSingleQuota`. |
Thu, 14 Feb, 09:23 |
| Mesos Reviewbot |
Re: Review Request 69994: Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`. |
Fri, 15 Feb, 22:06 |
| Mesos Reviewbot |
Re: Review Request 69615: Disable containerizer ptrace attach. |
Tue, 19 Feb, 22:06 |
| Mesos Reviewbot |
Re: Review Request 70002: Updated links to internal source files in documentation. |
Wed, 20 Feb, 00:43 |
| Mesos Reviewbot |
Re: Review Request 70001: Fixed an inaccurate comment in agent code. |
Wed, 20 Feb, 03:31 |
| Mesos Reviewbot |
Re: Review Request 70011: Modified `LOGROTATE_CustomRotateOptions` test after memfd change. |
Wed, 20 Feb, 05:55 |
| Mesos Reviewbot |
Re: Review Request 70014: Removed operations when removing resource providers. |
Wed, 20 Feb, 08:38 |
| Mesos Reviewbot |
Re: Review Request 70018: Avoided waiting for 180s when test `NvidiaDockerImage` fails. |
Wed, 20 Feb, 10:58 |
| Mesos Reviewbot |
Re: Review Request 70022: Added master load tests to cmake build. |
Wed, 20 Feb, 17:11 |
| Mesos Reviewbot |
Re: Review Request 70023: Fixed filename in warning message. |
Wed, 20 Feb, 19:41 |
| Mesos Reviewbot |
Re: Review Request 70011: Modified `LOGROTATE_CustomRotateOptions` test after memfd change. |
Wed, 20 Feb, 22:14 |
| Mesos Reviewbot |
Re: Review Request 67228: Added allocator benchmark test for various simulations. |
Wed, 20 Feb, 23:11 |
| Mesos Reviewbot |
Re: Review Request 67921: Bug fix for semaphore decomission "deadlock". |
Thu, 21 Feb, 01:43 |
| Mesos Reviewbot |
Re: Review Request 67968: Added logging to some containerizer destroy paths. |
Thu, 21 Feb, 04:31 |
| Mesos Reviewbot |
Re: Review Request 68187: Always built shared protobuf libraries. |
Thu, 21 Feb, 10:15 |
| Mesos Reviewbot |
Re: Review Request 65116: Getting Started using the Mesos Binaries. |
Thu, 21 Feb, 11:10 |
| Mesos Reviewbot |
Re: Review Request 68736: Added `task cat` command to new CLI. |
Thu, 21 Feb, 12:07 |
| Mesos Reviewbot |
Re: Review Request 68761: Made the actors in resource providers managed by libprocess. |
Thu, 21 Feb, 13:02 |
| Mesos Reviewbot |
Re: Review Request 68807: Used `Future::discard` to abort an outdated resuorce provider launches. |
Thu, 21 Feb, 15:45 |
| Mesos Reviewbot |
Re: Review Request 68814: Added a test for `Option<T&>` / `Option<const T&>`. |
Thu, 21 Feb, 18:13 |
| Mesos Reviewbot |
Re: Review Request 68508: Added tracking of framework allocations in the allocator Slave class. |
Thu, 21 Feb, 19:09 |
| Mesos Reviewbot |
Re: Review Request 68903: Avoid deadlock-prone blocking in master's parallel endpoint serving. |
Thu, 21 Feb, 20:26 |
| Mesos Reviewbot |
Re: Review Request 68919: Removed unbundling by default for libevent on macOS when using CMake. |
Thu, 21 Feb, 21:46 |
| Mesos Reviewbot |
Re: Review Request 68916: Moved libevent_openssl validation into libevent.m4. |
Thu, 21 Feb, 22:42 |
| Mesos Reviewbot |
Re: Review Request 68090: Added log_auto_compact flag to the master. |
Fri, 22 Feb, 01:14 |
| Mesos Reviewbot |
Re: Review Request 69325: WIP: Fixed CSI build problems for `make distcheck`. |
Fri, 22 Feb, 04:02 |
| Mesos Reviewbot |
Re: Review Request 69403: Removed empty filters in SLRP tests. |
Fri, 22 Feb, 06:57 |
| Mesos Reviewbot |
Re: Review Request 69313: Enabled parallel test runner to cmake build. |
Fri, 22 Feb, 09:25 |
| Mesos Reviewbot |
Re: Review Request 67185: Added request_protobuf to mesos.http. |
Fri, 22 Feb, 13:33 |
| Mesos Reviewbot |
Re: Review Request 68654: Enabled isort for src/python/lib. |
Fri, 22 Feb, 16:49 |
| Mesos Reviewbot |
Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings. |
Fri, 22 Feb, 19:18 |
| Mesos Reviewbot |
Re: Review Request 68785: Added jsonschema.py for managing json-based configs. |
Fri, 22 Feb, 21:50 |
| Mesos Reviewbot |
Re: Review Request 69551: Renamed `Metrics()` function in test utils. |
Fri, 22 Feb, 22:53 |
| Mesos Reviewbot |
Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script. |
Fri, 22 Feb, 23:53 |
| Mesos Reviewbot |
Re: Review Request 69701: Improved debuggability of `verify-reviews.py`. |
Sat, 23 Feb, 00:46 |
| Mesos Reviewbot |
Re: Review Request 67762: Added minimum capability check during master recovery. |
Sat, 23 Feb, 04:05 |
| Mesos Reviewbot |
Re: Review Request 69614: Reverted "Added `libacl` into a few Dockerfiles.". |
Sat, 23 Feb, 05:17 |
| Mesos Reviewbot |
Re: Review Request 67444: Made quota consumption tracking event-driven in the allocator. |
Sat, 23 Feb, 07:31 |
| Mesos Reviewbot |
Re: Review Request 69411: Added new interface for constructing `cluster::Master`. |
Sat, 23 Feb, 09:54 |
| Mesos Reviewbot |
Re: Review Request 70040: Added test for terminal operation updates after master failover. |
Sat, 23 Feb, 12:21 |
| Mesos Reviewbot |
Re: Review Request 70044: Moved status update streams of operations on agent's default resources. |
Sat, 23 Feb, 15:10 |
| Mesos Reviewbot |
Re: Review Request 70045: Skipped tests when verifying `master` as part of review verification. |
Sat, 23 Feb, 22:19 |
| Mesos Reviewbot |
Re: Review Request 70046: Prevented closing invalid file descriptors. |
Sun, 24 Feb, 00:40 |
| Mesos Reviewbot |
Re: Review Request 70048: Documented the new `--host_path_volume_force_creation` agent option. |
Mon, 25 Feb, 03:54 |
| Mesos Reviewbot |
Re: Review Request 70048: Documented the new `--host_path_volume_force_creation` agent option. |
Mon, 25 Feb, 03:55 |
| Mesos Reviewbot |
Re: Review Request 70049: Assured a set USER within RPM build. |
Mon, 25 Feb, 06:11 |
| Mesos Reviewbot |
Re: Review Request 70049: Assured a set USER within RPM build. |
Mon, 25 Feb, 06:20 |
| Mesos Reviewbot |
Re: Review Request 70040: Added test for terminal operation updates after master failover. |
Mon, 25 Feb, 22:56 |
| Mesos Reviewbot |
Re: Review Request 70053: Used std::string as buffer instead of manually managed dynamic array. |
Mon, 25 Feb, 23:47 |
| Mesos Reviewbot |
Re: Review Request 70053: Used std::string as buffer instead of manually managed dynamic array. |
Tue, 26 Feb, 01:16 |
| Mesos Reviewbot |
Re: Review Request 70054: Added FrameworkInfo.offer_filters to multi-scheduler scalability docs. |
Tue, 26 Feb, 02:12 |
| Mesos Reviewbot |
Re: Review Request 70054: Added FrameworkInfo.offer_filters to multi-scheduler scalability docs. |
Tue, 26 Feb, 03:21 |
| Mesos Reviewbot |
Re: Review Request 70044: Moved status update streams of operations on agent's default resources. |
Tue, 26 Feb, 20:49 |
| Mesos Reviewbot |
Re: Review Request 70044: Moved status update streams of operations on agent's default resources. |
Tue, 26 Feb, 20:57 |
| Mesos Reviewbot |
Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer. |
Tue, 26 Feb, 21:33 |
| Mesos Reviewbot |
Re: Review Request 67044: Renamed a method in the master metrics. |
Wed, 27 Feb, 00:10 |
| Mesos Reviewbot |
Re: Review Request 70060: Updated ReviewBot to catch diff updates recursively up the chain. |
Wed, 27 Feb, 01:49 |
| Mesos Reviewbot |
Re: Review Request 70060: Updated ReviewBot to catch diff updates recursively up the chain. |
Wed, 27 Feb, 02:14 |
| Mesos Reviewbot |
Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations. |
Wed, 27 Feb, 04:09 |
| Mesos Reviewbot |
Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations. |
Wed, 27 Feb, 04:22 |
| Mesos Reviewbot |
Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. |
Wed, 27 Feb, 20:50 |
| Mesos Reviewbot |
Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. |
Wed, 27 Feb, 21:00 |
| Mesos Reviewbot |
Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations. |
Thu, 28 Feb, 03:39 |
| Mesos Reviewbot |
Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations. |
Thu, 28 Feb, 03:53 |
| Mesos Reviewbot |
Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. |
Thu, 28 Feb, 06:25 |
| Mesos Reviewbot |
Re: Review Request 65869: Removed unnecessary warning in agent `statusUpdate()`. |
Thu, 28 Feb, 08:47 |
| Mesos Reviewbot |
Re: Review Request 65869: Removed unnecessary warning in agent `statusUpdate()`. |
Thu, 28 Feb, 08:50 |
| Mesos Reviewbot |
Re: Review Request 66150: WIP: Add -Werror semantics to CMake. |
Thu, 28 Feb, 11:03 |
| Mesos Reviewbot |
Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. |
Thu, 28 Feb, 22:54 |