| Clement Michaud |
Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources. |
Thu, 14 Feb, 12:53 |
| Gilbert Song |
Review Request 69946: Updated handleWhitelistFds() to avoid closing FDs with FD_CLOEXEC bit. |
Mon, 11 Feb, 19:21 |
| Gilbert Song |
Review Request 69947: Cloned a sealed file of launcher binary. |
Mon, 11 Feb, 19:21 |
| Gilbert Song |
Review Request 69948: Cleaned up command executor redundant command string. |
Mon, 11 Feb, 19:21 |
| Gilbert Song |
Re: Review Request 69943: Added Linux memfd support. |
Mon, 11 Feb, 19:27 |
| Gilbert Song |
Re: Review Request 69944: Made the code more robust related to sendfile. |
Mon, 11 Feb, 19:27 |
| Gilbert Song |
Re: Review Request 69945: Added a test to test memfd file clone. |
Mon, 11 Feb, 19:27 |
| Gilbert Song |
Re: Review Request 69946: Updated handleWhitelistFds() to avoid closing FDs with FD_CLOEXEC bit. |
Mon, 11 Feb, 19:33 |
| Gilbert Song |
Re: Review Request 69986: Added a log line to isolator for simplified debugging. |
Sat, 16 Feb, 00:39 |
| Gilbert Song |
Re: Review Request 69972: Handled containers which has no checkpointed volumes during recovery. |
Wed, 20 Feb, 21:40 |
| Gilbert Song |
Re: Review Request 69994: Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`. |
Wed, 20 Feb, 21:40 |
| Gilbert Song |
Re: Review Request 70001: Fixed an inaccurate comment in agent code. |
Wed, 20 Feb, 21:41 |
| Gilbert Song |
Re: Review Request 70037: Bumped SVN yum repo URL. |
Thu, 21 Feb, 19:00 |
| Gilbert Song |
Re: Review Request 70010: Store `logrotate` config in memfd file instead of container's sandbox. |
Thu, 21 Feb, 19:26 |
| Gilbert Song |
Re: Review Request 70011: Modified `LOGROTATE_CustomRotateOptions` test after memfd change. |
Thu, 21 Feb, 19:26 |
| Gilbert Song |
Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer. |
Thu, 21 Feb, 20:06 |
| Gilbert Song |
Re: Review Request 69287: Added test cases for the `volume/host_path` isolator. |
Thu, 21 Feb, 20:08 |
| Gilbert Song |
Re: Review Request 70009: Exposed `memfd_create` syscall via `createMemFd` function. |
Thu, 21 Feb, 20:16 |
| Gilbert Song |
Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer. |
Thu, 21 Feb, 23:58 |
| Gilbert Song |
Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer. |
Fri, 22 Feb, 02:29 |
| Gilbert Song |
Re: Review Request 69615: Disable containerizer ptrace attach. |
Fri, 22 Feb, 19:16 |
| Gilbert Song |
Re: Review Request 69342: Added an agent flag `--volume_gid_range`. |
Fri, 22 Feb, 22:38 |
| Gilbert Song |
Re: Review Request 69675: Added volume gid manager. |
Sat, 23 Feb, 07:02 |
| Gilbert Song |
Re: Review Request 69553: Changed the definition of `uid_t` and `gid_t` to UNIT for Windows. |
Sat, 23 Feb, 07:13 |
| Gilbert Song |
Re: Review Request 69479: Added the flag `--task_supplementary_groups` to command executor. |
Sat, 23 Feb, 07:14 |
| Gilbert Song |
Re: Review Request 69614: Reverted "Added `libacl` into a few Dockerfiles.". |
Sat, 23 Feb, 07:16 |
| Gilbert Song |
Re: Review Request 70048: Documented the new `--host_path_volume_force_creation` agent option. |
Mon, 25 Feb, 02:25 |
| Gilbert Song |
Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume. |
Mon, 25 Feb, 03:33 |
| Gilbert Song |
Re: Review Request 69478: Added `task_supplementary_groups` into `ContainerLaunchInfo`. |
Mon, 25 Feb, 03:33 |
| Gilbert Song |
Re: Review Request 69544: Made non-root containers can access shared persistent volume. |
Mon, 25 Feb, 03:43 |
| Gilbert Song |
Re: Review Request 69481: Deallocated the shared persistent volume's gid when it is removed. |
Mon, 25 Feb, 03:43 |
| Gilbert Song |
Re: Review Request 69676: Implemented recovery for volume gid manager. |
Mon, 25 Feb, 03:43 |
| Gilbert Song |
Re: Review Request 67997: Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`. |
Mon, 25 Feb, 03:44 |
| Gilbert Song |
Re: Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`. |
Mon, 25 Feb, 03:44 |
| Gilbert Song |
Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`. |
Mon, 25 Feb, 03:44 |
| Gilbert Song |
Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`. |
Mon, 25 Feb, 03:44 |
| Gilbert Song |
Re: Review Request 69579: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxLocalPersistentVolume`. |
Mon, 25 Feb, 03:44 |
| Gilbert Song |
Re: Review Request 69613: Added tests for volume gid manager. |
Mon, 25 Feb, 03:44 |
| Gilbert Song |
Re: Review Request 69675: Added volume gid manager. |
Mon, 25 Feb, 19:42 |
| Gilbert Song |
Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume. |
Mon, 25 Feb, 19:50 |
| Gilbert Song |
Re: Review Request 69544: Made non-root containers can access shared persistent volume. |
Mon, 25 Feb, 20:00 |
| Gilbert Song |
Re: Review Request 69675: Added volume gid manager. |
Thu, 28 Feb, 00:50 |
| Gilbert Song |
Re: Review Request 69342: Added an agent flag `--volume_gid_range`. |
Thu, 28 Feb, 00:51 |
| Gilbert Song |
Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume. |
Thu, 28 Feb, 00:51 |
| Gilbert Song |
Re: Review Request 69544: Made non-root containers can access shared persistent volume. |
Thu, 28 Feb, 01:09 |
| Gilbert Song |
Re: Review Request 69676: Implemented recovery for volume gid manager. |
Thu, 28 Feb, 01:24 |
| Gilbert Song |
Re: Review Request 67997: Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`. |
Thu, 28 Feb, 01:30 |
| Gilbert Song |
Re: Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`. |
Thu, 28 Feb, 01:31 |
| Gilbert Song |
Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`. |
Thu, 28 Feb, 01:35 |
| Gilbert Song |
Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`. |
Thu, 28 Feb, 01:35 |
| Gilbert Song |
Re: Review Request 69579: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxLocalPersistentVolume`. |
Thu, 28 Feb, 01:35 |
| Gilbert Song |
Re: Review Request 69613: Added tests for volume gid manager. |
Thu, 28 Feb, 01:36 |
| Gilbert Song |
Re: Review Request 69676: Implemented recovery for volume gid manager. |
Thu, 28 Feb, 06:17 |
| GitBox |
[GitHub] jdef commented on a change in pull request #294: FaultDomain, conventions for additional hierarchy. |
Fri, 15 Feb, 15:16 |
| GitBox |
[GitHub] vinodkone merged pull request #294: FaultDomain, conventions for additional hierarchy. |
Sat, 16 Feb, 02:25 |
| Greg Mann |
Review Request 69880: Added header comments for two master methods. |
Sat, 02 Feb, 01:16 |
| Greg Mann |
Re: Review Request 69880: Added header comments for two master methods. |
Mon, 04 Feb, 21:41 |
| Greg Mann |
Review Request 69891: Sent operation updates to schedulers when agents are removed. |
Tue, 05 Feb, 16:24 |
| Greg Mann |
Re: Review Request 69871: Added more documentation for operation feedback. |
Tue, 05 Feb, 16:33 |
| Greg Mann |
Re: Review Request 69891: Sent operation updates to schedulers when agents are removed. |
Tue, 05 Feb, 17:18 |
| Greg Mann |
Re: Review Request 69854: Set status update UUID in MockResourceProvider. |
Tue, 05 Feb, 17:30 |
| Greg Mann |
Re: Review Request 69891: Sent operation updates to schedulers when agents are removed. |
Thu, 07 Feb, 16:39 |
| Greg Mann |
Re: Review Request 69910: Added tests for feedback for operations on agent default resources. |
Thu, 07 Feb, 17:24 |
| Greg Mann |
Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources. |
Thu, 07 Feb, 18:09 |
| Greg Mann |
Re: Review Request 69912: Added agent/RP IDs to some operation updates generated by the master. |
Thu, 07 Feb, 18:15 |
| Greg Mann |
Re: Review Request 69913: Added more operation reconciliation tests. |
Thu, 07 Feb, 18:32 |
| Greg Mann |
Re: Review Request 69880: Added header comments for two master methods. |
Thu, 07 Feb, 22:08 |
| Greg Mann |
Re: Review Request 69876: Removed operations from master state when an agent is downgraded. |
Thu, 07 Feb, 22:56 |
| Greg Mann |
Review Request 69922: Added test to verify that frameworks receive OPERATION_DROPPED updates. |
Thu, 07 Feb, 23:23 |
| Greg Mann |
Re: Review Request 69919: Added missing periods at the end of comments. |
Fri, 08 Feb, 00:29 |
| Greg Mann |
Re: Review Request 69910: Added tests for feedback for operations on agent default resources. |
Fri, 08 Feb, 00:30 |
| Greg Mann |
Re: Review Request 69910: Added tests for feedback for operations on agent default resources. |
Fri, 08 Feb, 00:32 |
| Greg Mann |
Re: Review Request 69920: Removed `MasterAPITest.OperationFeedbackOnAgentDefaultResources`. |
Fri, 08 Feb, 00:32 |
| Greg Mann |
Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources. |
Fri, 08 Feb, 00:36 |
| Greg Mann |
Re: Review Request 69922: Added test to verify that frameworks receive OPERATION_DROPPED updates. |
Fri, 08 Feb, 01:29 |
| Greg Mann |
Re: Review Request 69922: Added test to verify that frameworks receive OPERATION_DROPPED updates. |
Fri, 08 Feb, 01:44 |
| Greg Mann |
Re: Review Request 69922: Added test to verify that frameworks receive OPERATION_DROPPED updates. |
Fri, 08 Feb, 05:50 |
| Greg Mann |
Re: Review Request 69876: Removed operations from master state when an agent is downgraded. |
Tue, 12 Feb, 21:35 |
| Greg Mann |
Re: Review Request 69876: Removed operations from master state when an agent is downgraded. |
Tue, 12 Feb, 21:36 |
| Greg Mann |
Re: Review Request 69891: Sent operation updates to schedulers when agents are removed. |
Tue, 12 Feb, 21:38 |
| Greg Mann |
Re: Review Request 69880: Added header comments for two master methods. |
Tue, 12 Feb, 21:38 |
| Greg Mann |
Re: Review Request 69876: Removed operations from master state when an agent is downgraded. |
Tue, 12 Feb, 21:42 |
| Greg Mann |
Re: Review Request 69876: Removed operations from master state when an agent is downgraded. |
Tue, 12 Feb, 21:43 |
| Greg Mann |
Review Request 69957: Updated master operation handling to account for new agent capability. |
Tue, 12 Feb, 21:48 |
| Greg Mann |
Review Request 69958: Made an agent capability required for agent startup. |
Tue, 12 Feb, 21:49 |
| Greg Mann |
Re: Review Request 69958: Made an agent capability required for agent startup. |
Tue, 12 Feb, 21:53 |
| Greg Mann |
Re: Review Request 69957: Updated master operation handling to account for new agent capability. |
Tue, 12 Feb, 23:39 |
| Greg Mann |
Re: Review Request 69876: Removed operations from master state when an agent is downgraded. |
Tue, 12 Feb, 23:39 |
| Greg Mann |
Review Request 69964: Added tests related to operation feedback agent capabilities. |
Tue, 12 Feb, 23:42 |
| Greg Mann |
Review Request 69969: Updated docs related to agent capabilities. |
Wed, 13 Feb, 02:08 |
| Greg Mann |
Re: Review Request 69957: Updated master operation handling to account for new agent capability. |
Wed, 13 Feb, 02:37 |
| Greg Mann |
Re: Review Request 69957: Updated master operation handling to account for new agent capability. |
Wed, 13 Feb, 02:37 |
| Greg Mann |
Re: Review Request 69964: Added tests related to operation feedback agent capabilities. |
Wed, 13 Feb, 02:38 |
| Greg Mann |
Re: Review Request 69964: Added tests related to operation feedback agent capabilities. |
Wed, 13 Feb, 02:39 |
| Greg Mann |
Re: Review Request 69969: Updated docs related to agent capabilities. |
Wed, 13 Feb, 02:46 |
| Greg Mann |
Re: Review Request 69968: Copied operation removal logic in agent removal code path. |
Wed, 13 Feb, 20:32 |
| Greg Mann |
Re: Review Request 69957: Updated master operation handling to account for new agent capability. |
Thu, 14 Feb, 04:09 |
| Greg Mann |
Re: Review Request 69963: Handled terminal operation status updates for orphans. |
Thu, 14 Feb, 18:45 |
| Greg Mann |
Re: Review Request 69967: Added a recovery path for orphan operation. |
Thu, 14 Feb, 19:07 |
| Greg Mann |
Re: Review Request 69980: Modified when master responds to operation status updates. |
Thu, 14 Feb, 20:31 |