| Benjamin Bannier |
Re: Review Request 69889: Stored static framework offer filters in allocator framework class. |
Fri, 08 Feb, 11:32 |
| Benjamin Bannier |
Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator. |
Fri, 08 Feb, 11:32 |
| Benjamin Bannier |
Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources. |
Fri, 08 Feb, 11:32 |
| Benjamin Bannier |
Re: Review Request 69889: Stored static framework offer filters in allocator framework class. |
Fri, 08 Feb, 11:32 |
| Benjamin Bannier |
Re: Review Request 69889: Stored static framework offer filters in allocator framework class. |
Fri, 08 Feb, 11:32 |
| Benjamin Bannier |
Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator. |
Fri, 08 Feb, 11:32 |
| Benjamin Bannier |
Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources. |
Fri, 08 Feb, 11:32 |
| Benjamin Bannier |
Re: Review Request 69818: Added offer filters to static framework configuration. |
Fri, 08 Feb, 11:33 |
| Benjamin Bannier |
Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator. |
Mon, 11 Feb, 15:46 |
| Benjamin Bannier |
Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources. |
Mon, 11 Feb, 15:46 |
| Benjamin Bannier |
Re: Review Request 69889: Stored static framework offer filters in allocator framework class. |
Mon, 11 Feb, 16:19 |
| Benjamin Bannier |
Re: Review Request 69818: Added offer filters to static framework configuration. |
Mon, 11 Feb, 16:19 |
| Benjamin Bannier |
Re: Review Request 69818: Added offer filters to static framework configuration. |
Mon, 11 Feb, 16:20 |
| Benjamin Bannier |
Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources. |
Mon, 11 Feb, 17:28 |
| Benjamin Bannier |
Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator. |
Mon, 11 Feb, 17:28 |
| Benjamin Bannier |
Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources. |
Tue, 12 Feb, 08:34 |
| Benjamin Bannier |
Re: Review Request 69858: Persisted intentionally dropped operations in SLRP. |
Tue, 12 Feb, 08:45 |
| Benjamin Bannier |
Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedback. |
Tue, 12 Feb, 12:19 |
| Benjamin Bannier |
Re: Review Request 69892: Made SLRP recover node-published volumes after reboot. |
Tue, 12 Feb, 13:24 |
| Benjamin Bannier |
Re: Review Request 69893: Clean up persistent volumes on SLRP disks. |
Tue, 12 Feb, 14:00 |
| Benjamin Bannier |
Re: Review Request 69893: Clean up persistent volumes on SLRP disks. |
Tue, 12 Feb, 14:00 |
| Benjamin Bannier |
Re: Review Request 69895: Made SLRP `PublishResources` test to check persistent volume cleanup. |
Tue, 12 Feb, 14:21 |
| Benjamin Bannier |
Re: Review Request 69896: Made SLRP `PublishResourcesReboot` test to check persistent volume cleanup. |
Tue, 12 Feb, 14:30 |
| Benjamin Bannier |
Re: Review Request 69896: Made SLRP `PublishResourcesReboot` test to check persistent volume cleanup. |
Tue, 12 Feb, 14:30 |
| Benjamin Bannier |
Re: Review Request 69897: Made SLRP `PublishResourcesRecovery` test to check volume cleanup. |
Tue, 12 Feb, 14:33 |
| Benjamin Bannier |
Re: Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations. |
Tue, 12 Feb, 15:10 |
| Benjamin Bannier |
Re: Review Request 69904: Extracted common offer matching functions from SLRP tests. |
Tue, 12 Feb, 15:16 |
| Benjamin Bannier |
Re: Review Request 69905: Added a SLRP unit test for failed persistent volume cleanup. |
Tue, 12 Feb, 17:40 |
| Benjamin Bannier |
Re: Review Request 69942: Added a test for MESOS-9554. |
Tue, 12 Feb, 18:34 |
| Benjamin Bannier |
Re: Review Request 69892: Made SLRP recover node-published volumes after reboot. |
Tue, 12 Feb, 21:06 |
| Benjamin Bannier |
Re: Review Request 69942: Added a test for MESOS-9554. |
Tue, 12 Feb, 21:21 |
| Benjamin Bannier |
Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator. |
Wed, 13 Feb, 15:44 |
| Benjamin Bannier |
Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources. |
Wed, 13 Feb, 22:31 |
| Benjamin Bannier |
Re: Review Request 69862: Validated static framework offer filters. |
Wed, 13 Feb, 22:31 |
| Benjamin Bannier |
Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources. |
Wed, 13 Feb, 22:32 |
| Benjamin Bannier |
Re: Review Request 69818: Added offer filters to static framework configuration. |
Thu, 14 Feb, 20:45 |
| Benjamin Bannier |
Re: Review Request 69862: Validated static framework offer filters. |
Thu, 14 Feb, 20:46 |
| Benjamin Bannier |
Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources. |
Thu, 14 Feb, 20:48 |
| Benjamin Bannier |
Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources. |
Thu, 14 Feb, 20:48 |
| Benjamin Bannier |
Review Request 69999: Fixed some lint issues in verify-reviews.py. |
Sun, 17 Feb, 17:48 |
| Benjamin Bannier |
Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely. |
Sun, 17 Feb, 17:48 |
| Benjamin Bannier |
Review Request 69998: Reformated verify-reviews.py with yapf. |
Sun, 17 Feb, 17:48 |
| Benjamin Bannier |
Re: Review Request 69994: Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`. |
Mon, 18 Feb, 14:25 |
| Benjamin Bannier |
Re: Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations. |
Mon, 18 Feb, 17:14 |
| Benjamin Bannier |
Re: Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely. |
Tue, 19 Feb, 10:43 |
| Benjamin Bannier |
Re: Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely. |
Tue, 19 Feb, 16:44 |
| Benjamin Bannier |
Re: Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely. |
Tue, 19 Feb, 16:53 |
| Benjamin Bannier |
Re: Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely. |
Tue, 19 Feb, 16:53 |
| Benjamin Bannier |
Re: Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely. |
Tue, 19 Feb, 17:10 |
| Benjamin Bannier |
Re: Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely. |
Tue, 19 Feb, 17:10 |
| Benjamin Bannier |
Re: Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely. |
Tue, 19 Feb, 17:23 |
| Benjamin Bannier |
Review Request 70012: Fixed type error in verify-reviews.py. |
Tue, 19 Feb, 20:45 |
| Benjamin Bannier |
Re: Review Request 70022: Added master load tests to cmake build. |
Wed, 20 Feb, 15:17 |
| Benjamin Bannier |
Re: Review Request 70022: Added master load tests to cmake build. |
Wed, 20 Feb, 16:29 |
| Benjamin Bannier |
Re: Review Request 70026: Increased the number of review requests queried by ReviewBot to 200. |
Wed, 20 Feb, 21:29 |
| Benjamin Bannier |
Review Request 70034: Consistently used `override` in tests' `BlockingAuthorizer`. |
Thu, 21 Feb, 11:33 |
| Benjamin Bannier |
Re: Review Request 70022: Added master load tests to cmake build. |
Thu, 21 Feb, 11:33 |
| Benjamin Bannier |
Review Request 70045: Skipped tests when verifying `master` as part of review verification. |
Sat, 23 Feb, 20:18 |
| Benjamin Bannier |
Review Request 70046: Prevented closing invalid file descriptors. |
Sat, 23 Feb, 20:41 |
| Benjamin Bannier |
Re: Review Request 70045: Skipped tests when verifying `master` as part of review verification. |
Sun, 24 Feb, 07:55 |
| Benjamin Bannier |
Re: Review Request 70045: Skipped tests when verifying `master` as part of review verification. |
Sun, 24 Feb, 22:03 |
| Benjamin Bannier |
Re: Review Request 69676: Implemented recovery for volume gid manager. |
Mon, 25 Feb, 14:15 |
| Benjamin Bannier |
Re: Review Request 69675: Added volume gid manager. |
Mon, 25 Feb, 14:15 |
| Benjamin Bannier |
Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume. |
Mon, 25 Feb, 14:15 |
| Benjamin Bannier |
Re: Review Request 70046: Prevented closing invalid file descriptors. |
Mon, 25 Feb, 21:19 |
| Benjamin Bannier |
Re: Review Request 70046: Prevented closing invalid file descriptors. |
Mon, 25 Feb, 21:19 |
| Benjamin Bannier |
Review Request 70053: Used std::string as buffer instead of manually managed dynamic array. |
Mon, 25 Feb, 21:20 |
| Benjamin Bannier |
Re: Review Request 70053: Used std::string as buffer instead of manually managed dynamic array. |
Mon, 25 Feb, 22:21 |
| Benjamin Bannier |
Re: Review Request 70060: Updated ReviewBot to catch diff updates recursively up the chain. |
Wed, 27 Feb, 12:02 |
| Benjamin Bannier |
Re: Review Request 69970: Made SLRP clean up mount directories for destroyed MOUNT disks. |
Wed, 27 Feb, 13:53 |
| Benjamin Bannier |
Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. |
Wed, 27 Feb, 19:14 |
| Benjamin Bannier |
Re: Review Request 70049: Assured a set USER within RPM build. |
Thu, 28 Feb, 20:52 |
| Benjamin Bannier |
Re: Review Request 70047: Updated build specific artefact generation. |
Fri, 01 Mar, 00:02 |
| Benjamin Mahler |
Re: Review Request 69885: Sped up some resource benchmark test instantiations. |
Mon, 04 Feb, 18:22 |
| Benjamin Mahler |
Re: Review Request 69818: Added offer filters to static framework configuration. |
Mon, 04 Feb, 20:31 |
| Benjamin Mahler |
Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator. |
Mon, 04 Feb, 20:58 |
| Benjamin Mahler |
Re: Review Request 69885: Sped up some resource benchmark test instantiations. |
Mon, 04 Feb, 21:02 |
| Benjamin Mahler |
Re: Review Request 69889: Stored static framework offer filters in allocator framework class. |
Tue, 05 Feb, 18:40 |
| Benjamin Mahler |
Re: Review Request 69889: Stored static framework offer filters in allocator framework class. |
Tue, 05 Feb, 18:42 |
| Benjamin Mahler |
Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources. |
Tue, 05 Feb, 19:03 |
| Benjamin Mahler |
Re: Review Request 69889: Stored static framework offer filters in allocator framework class. |
Tue, 05 Feb, 19:13 |
| Benjamin Mahler |
Review Request 69900: Reduced unnecessary agent lookups in the allocation loops. |
Tue, 05 Feb, 22:30 |
| Benjamin Mahler |
Review Request 69902: Fixed incorrect skipping in the allocation loops. |
Tue, 05 Feb, 22:30 |
| Benjamin Mahler |
Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator. |
Tue, 05 Feb, 22:35 |
| Benjamin Mahler |
Re: Review Request 69902: Fixed incorrect skipping in the allocation loops. |
Wed, 06 Feb, 18:52 |
| Benjamin Mahler |
Re: Review Request 69902: Fixed incorrect skipping in the allocation loops. |
Wed, 06 Feb, 18:56 |
| Benjamin Mahler |
Re: Review Request 69902: Fixed incorrect skipping in the allocation loops. |
Wed, 06 Feb, 19:00 |
| Benjamin Mahler |
Re: Review Request 69889: Stored static framework offer filters in allocator framework class. |
Fri, 08 Feb, 20:35 |
| Benjamin Mahler |
Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources. |
Fri, 08 Feb, 20:47 |
| Benjamin Mahler |
Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator. |
Fri, 08 Feb, 21:05 |
| Benjamin Mahler |
Re: Review Request 69902: Fixed incorrect skipping in the allocation loops. |
Fri, 08 Feb, 21:47 |
| Benjamin Mahler |
Review Request 69942: Added a test for MESOS-9554. |
Mon, 11 Feb, 18:21 |
| Benjamin Mahler |
Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources. |
Mon, 11 Feb, 18:58 |
| Benjamin Mahler |
Re: Review Request 69942: Added a test for MESOS-9554. |
Tue, 12 Feb, 19:23 |
| Benjamin Mahler |
Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources. |
Tue, 12 Feb, 20:01 |
| Benjamin Mahler |
Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources. |
Tue, 12 Feb, 20:21 |
| Benjamin Mahler |
Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator. |
Tue, 12 Feb, 20:39 |
| Benjamin Mahler |
Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources. |
Tue, 12 Feb, 20:51 |
| Benjamin Mahler |
Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator. |
Wed, 13 Feb, 19:08 |
| Benjamin Mahler |
Re: Review Request 69981: Fixed a flaky test `MasterQuotaTest.RemoveSingleQuota`. |
Thu, 14 Feb, 17:12 |