mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 67762: Added minimum capability check during master recovery.
Date Thu, 28 Feb 2019 23:09:30 GMT


> On Feb. 26, 2019, 6:04 p.m., Joseph Wu wrote:
> > src/master/master.cpp
> > Lines 1680 (patched)
> > <https://reviews.apache.org/r/67762/diff/4/?file=2125976#file2125976line1680>
> >
> >     A forced recovery doesn't really make sense, if we're trying to prevent undefined
behavior.  If a recovery must be forced, and lacking any other context, my recommendation
would be purging the registry and starting the cluster anew.

Removed.


> On Feb. 26, 2019, 6:04 p.m., Joseph Wu wrote:
> > src/master/master.cpp
> > Lines 1682-1684 (patched)
> > <https://reviews.apache.org/r/67762/diff/4/?file=2125976#file2125976line1682>
> >
> >     I wonder if we should start a document (even blank?) which lists each minimum
capability, some background, and how to recover from each.
> >     
> >     Using quota limits as an example, the recovery steps might be to launch the
newer master, and send operator calls modifying all quotas into a backwards compatible form.
> >     
> >     ---
> >     
> >     We can then link the document in the error message as a fallback.

Done. Added a doc in https://reviews.apache.org/r/70077/.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67762/#review213241
-----------------------------------------------------------


On Feb. 28, 2019, 3:08 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67762/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2019, 3:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-8880
>     https://issues.apache.org/jira/browse/MESOS-8880
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new registry field `minimum_capabilities`
> to faciliatate safe downgrade of masters.  This is a list
> of strings which will be written whenever the master uses a
> feature that may be backwards incompatible.  If an older master
> sees an unknown feature in the list, the older master will
> refuse to recover and try to provide remediation steps instead.
> 
> Also see: MESOS-8878.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 48f30b3f41f3440245c1912becc9c2c3d572aff9 
>   include/mesos/v1/mesos.proto e07dd9e42939fddcff5d15072a143d9c4c44dd3d 
>   src/master/master.hpp aceab3455adfdf7ff6e168e033316997a4d36fb5 
>   src/master/master.cpp 665c1c7979a5ae4ecec0d5a68e59c5419049a4d5 
>   src/tests/master_tests.cpp 5ae8e1cea3ca87551093bd63d744ac807ac7797a 
> 
> 
> Diff: https://reviews.apache.org/r/67762/diff/5/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message