mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 67762: Added minimum capability check during master recovery.
Date Thu, 28 Feb 2019 23:08:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67762/
-----------------------------------------------------------

(Updated Feb. 28, 2019, 3:08 p.m.)


Review request for mesos, Benjamin Mahler and Joseph Wu.


Changes
-------

Addressed kaysoky's comments.


Bugs: MESOS-8880
    https://issues.apache.org/jira/browse/MESOS-8880


Repository: mesos


Description (updated)
-------

This patch adds a new registry field `minimum_capabilities`
to faciliatate safe downgrade of masters.  This is a list
of strings which will be written whenever the master uses a
feature that may be backwards incompatible.  If an older master
sees an unknown feature in the list, the older master will
refuse to recover and try to provide remediation steps instead.

Also see: MESOS-8878.


Diffs (updated)
-----

  include/mesos/mesos.proto 48f30b3f41f3440245c1912becc9c2c3d572aff9 
  include/mesos/v1/mesos.proto e07dd9e42939fddcff5d15072a143d9c4c44dd3d 
  src/master/master.hpp aceab3455adfdf7ff6e168e033316997a4d36fb5 
  src/master/master.cpp 665c1c7979a5ae4ecec0d5a68e59c5419049a4d5 
  src/tests/master_tests.cpp 5ae8e1cea3ca87551093bd63d744ac807ac7797a 


Diff: https://reviews.apache.org/r/67762/diff/5/

Changes: https://reviews.apache.org/r/67762/diff/4-5/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message