mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66150: WIP: Add -Werror semantics to CMake.
Date Thu, 28 Feb 2019 11:03:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66150/#review213302
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66150]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On March 19, 2018, 8:34 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66150/
> -----------------------------------------------------------
> 
> (Updated March 19, 2018, 8:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Bugs: MESOS-8689
>     https://issues.apache.org/jira/browse/MESOS-8689
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This WIP patch has two options for turning on -Werror, either apply it
> as a compile option to the `src` directory recursively, or use
> `SET_WERROR(TARGETS foo)` to apply it to each desired target
> individually.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c 
>   docs/configuration/cmake.md 1e34657ea55fa324f65f865f7d0a67084c6719d9 
>   src/CMakeLists.txt fb9e9d4cfc4a62830fe3065a139ae14401c0e52e 
> 
> 
> Diff: https://reviews.apache.org/r/66150/diff/1/
> 
> 
> Testing
> -------
> 
> This is just showing some of our options.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message