mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69904: Extracted common offer matching functions from SLRP tests.
Date Thu, 28 Feb 2019 00:23:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69904/
-----------------------------------------------------------

(Updated Feb. 28, 2019, 12:23 a.m.)


Review request for mesos and Benjamin Bannier.


Changes
-------

Rebased.


Bugs: MESOS-9565
    https://issues.apache.org/jira/browse/MESOS-9565


Repository: mesos


Description
-------

This patch extracts lambda functions `isStoragePool`, `isMountDisk` and
`isPreprovisionedVolume` from all tests and makes them common utitily
functions in the test fixture.


Diffs (updated)
-----

  src/tests/storage_local_resource_provider_tests.cpp a661951a0a326cc342aa0c45dd0967692ae70941



Diff: https://reviews.apache.org/r/69904/diff/4/

Changes: https://reviews.apache.org/r/69904/diff/3-4/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message