mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.
Date Wed, 27 Feb 2019 19:14:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213266
-----------------------------------------------------------



Thanks for adding these!

Like Ben said, let's link this to MESOS-7124. Let's additionally create a ticket linked there
for writing a linter to catch uses of `get` where `operator*` should be used (this could be
modelled based on the existing `mesos-redundant-get` linter).


3rdparty/stout/include/stout/option.hpp
Lines 127 (patched)
<https://reviews.apache.org/r/70067/#comment299199>

    I feel we should disable this one for rvalues (which should also have been done for `T*
operator->`).
    ```
    T& operator*() & { return get(); }
    ```



3rdparty/stout/include/stout/result.hpp
Lines 138 (patched)
<https://reviews.apache.org/r/70067/#comment299197>

    Disable for rvalues?



3rdparty/stout/include/stout/try.hpp
Lines 82 (patched)
<https://reviews.apache.org/r/70067/#comment299198>

    Disable for rvalues?


- Benjamin Bannier


On Feb. 27, 2019, 7:15 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2019, 7:15 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added star operator for `Result`, `Try` and `Option`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9 
>   3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3 
>   3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444 
>   3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c 
>   3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41 
>   3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1 
> 
> 
> Diff: https://reviews.apache.org/r/70067/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message