mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69970: Made SLRP clean up mount directories for destroyed MOUNT disks.
Date Wed, 27 Feb 2019 13:53:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69970/#review213255
-----------------------------------------------------------


Fix it, then Ship it!





src/csi/paths.cpp
Lines 285-286 (patched)
<https://reviews.apache.org/r/69970/#comment299172>

    Fits on a line.



src/csi/paths.cpp
Lines 285-289 (patched)
<https://reviews.apache.org/r/69970/#comment299175>

    I wonder whether it makes more sense to just inline this definition and get rid of the
function (for now).



src/csi/paths.cpp
Lines 292-294 (patched)
<https://reviews.apache.org/r/69970/#comment299173>

    Fits on a line.



src/csi/paths.cpp
Lines 316-321 (patched)
<https://reviews.apache.org/r/69970/#comment299174>

    If this function would accept a `const Path& dir` we wouldn't need to create the temporary
paths (there's a `Path::string` function to get a string representation).
    
    That being said, `Path` is very underappreciated in our code base, so feel free to drop.



src/resource_provider/storage/provider.cpp
Lines 975-980 (patched)
<https://reviews.apache.org/r/69970/#comment299176>

    This almost seems like a hard error to me (but would introduce coupling). Maybe just inline
the function here and possibly assert.



src/resource_provider/storage/provider.cpp
Lines 2375 (patched)
<https://reviews.apache.org/r/69970/#comment299177>

    Let's put the comment on `mkdir` below.



src/resource_provider/storage/provider.cpp
Lines 2482 (patched)
<https://reviews.apache.org/r/69970/#comment299178>

    Let's put the comment on `mkdir` below.


- Benjamin Bannier


On Feb. 13, 2019, 6:54 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69970/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2019, 6:54 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
> 
> 
> Bugs: MESOS-9568
>     https://issues.apache.org/jira/browse/MESOS-9568
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the SLRP stage/publish a CSI volume, it creates the staging/target
> paths, but only the target path is cleaned up during unpublish.
> Moreover, even if the CSI plugin does not support node-staging, the
> current cleanup is still not enough, as the parent directory of the
> target path is not removed. This patch fixes this problem.
> 
> 
> Diffs
> -----
> 
>   src/csi/paths.hpp 7a4e9e0e85ca33c8be0a16ff4531c765f40e0adc 
>   src/csi/paths.cpp 772d960d96d481949cf25bc464e39e1ec15cd27d 
>   src/resource_provider/storage/provider.cpp 09a710d668a5a7460b6c4e4fa32d3829dca7ac55

>   src/resource_provider/storage/provider_process.hpp 36187fb4a25c49653530ee286fa9c1663177fbc6

> 
> 
> Diff: https://reviews.apache.org/r/69970/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message