mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 67761: Added a new registry field `minimum_capabilities`.
Date Wed, 27 Feb 2019 01:47:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67761/#review213238
-----------------------------------------------------------


Ship it!




I feel the patch description is a bit lacking.  Refering to the JIRA is fine, but it does
not hurt to summarize the JIRA's purpose too.

Suggestion:
```
This patch adds a new registry field `minimum_capabilities`
to faciliatate safe downgrade of masters.  This is a list of strings
which will be written whenever the master uses a feature that may
be backwards incompatible.  If an older master sees an unknown feature
in the list, the older master will refuse to recover and try to provide
remediation steps instead.

Also see: MESOS-8878.
```

- Joseph Wu


On June 29, 2018, 3:48 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67761/
> -----------------------------------------------------------
> 
> (Updated June 29, 2018, 3:48 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-8880
>     https://issues.apache.org/jira/browse/MESOS-8880
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new registry field `minimum_capabilities`
> to faciliatate safe downgrade. See MESOS-8878.
> 
> 
> Diffs
> -----
> 
>   src/master/registry.proto cac0c3196aed601ba41c337e8d746819ce42f8d9 
> 
> 
> Diff: https://reviews.apache.org/r/67761/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message