mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 67044: Renamed a method in the master metrics.
Date Wed, 27 Feb 2019 00:10:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67044/#review213237
-----------------------------------------------------------



Bad review!

Reviews applied: [67044]

Error:
2019-02-27 00:10:54 URL:https://reviews.apache.org/r/67044/diff/raw/ [3246/3246] -> "67044.patch"
[1]
error: patch failed: src/master/master.cpp:10908
error: src/master/master.cpp: patch does not apply
error: patch failed: src/master/metrics.hpp:210
error: src/master/metrics.hpp: patch does not apply

- Mesos Reviewbot


On May 14, 2018, 10:30 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67044/
> -----------------------------------------------------------
> 
> (Updated May 14, 2018, 10:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed a method in the master metrics.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
> 
> 
> Diff: https://reviews.apache.org/r/67044/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message