mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 69978: Added garbage collection of terminated operations status update streams.
Date Wed, 27 Feb 2019 00:05:37 GMT


> On Feb. 26, 2019, 3:16 p.m., Joseph Wu wrote:
> > src/slave/slave.cpp
> > Lines 4694 (patched)
> > <https://reviews.apache.org/r/69978/diff/5/?file=2126441#file2126441line4694>
> >
> >     Is there any reason why this is not the following?
> >     ```
> >     operation->latest_status().state()
> >     ```

Not that I can think of, changing it would be a nice readibility improvement =).


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69978/#review213234
-----------------------------------------------------------


On Feb. 22, 2019, 5:28 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69978/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2019, 5:28 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-9574
>     https://issues.apache.org/jira/browse/MESOS-9574
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Make the agent garbage collect an operation status update stream once
> a terminal status update is acknowledged.
> 
> This patch also improves the logging of acknowledgement failures and the
> readability of the `Slave::operationStatusAcknowledgement` method.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79 
> 
> 
> Diff: https://reviews.apache.org/r/69978/diff/5/
> 
> 
> Testing
> -------
> 
> Manual testing + existing tests still pass.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message