mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 69869: Added test for tearing down frameworks while creating disks.
Date Tue, 26 Feb 2019 19:24:59 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 26, 2019, 11:24 a.m.)

Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.


Comment tweak only.

Bugs: MESOS-9542

Repository: mesos


The CREATE_DISK and DESTROY_DISK operations are "non-speculative"
operations, which means the master must wait for the operations to
complete successfully before the master can update its resources.
Because the master must wait to update the results of non-speculative
operations, it is possible for the framework making the
CREATE/DESTROY_DISK to be torn down before the operation completes.

This commit adds a test to make sure the master can gracefully handle
such a case.

Diffs (updated)

  src/tests/storage_local_resource_provider_tests.cpp a661951a0a326cc342aa0c45dd0967692ae70941




src/mesos-tests --gtest_filter="StorageLocalResourceProviderTest.FrameworkTeardownBeforeTerminalOperationStatusUpdate"

One more test added next patch.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message