mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <>
Subject Re: Review Request 70047: Updated build specific artefact generation.
Date Tue, 26 Feb 2019 02:18:37 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 26, 2019, 2:18 a.m.)

Review request for mesos, Benjamin Bannier and Joseph Wu.

Bugs: MESOS-9605

Repository: mesos

Description (updated)

For autotools, we extracted additional build info like the git branch
and sha during the automake phase handing them into libbuild via
commandline supplied defines.

CMake builds however used a configuration file for this purpose.

This patch updates both build systems to make use of for build specific git information. The data
is persisted only once for the initial configuration / cmake run.
Subsequent invocations will not update build_git_config.hpp. We do
this to make sure that snapshots can get built without having git
specific information available at build time.

Diffs (updated)

  cmake/CompilationConfigure.cmake c330324e2e3dea6e71980ae8c9ed71632ebb018e ee29fc784e53ebaf1bb016c33136b200c646ee9b 
  src/ 283d5ed89b36d74da36f38c26aec03c6129d6261 
  src/common/build.cpp f5271d87d33ac429fb94093a347be1d6c25d3432 
  src/common/ 4cce2403c1d7a5feee8fd2fffa7cf4308507cd0c 
  src/common/ PRE-CREATION 



Testing (updated)

Manually tested both cmake and autotools.

First configure run:
checking for src/common/build_git_config.hpp... no
configure: creating src/common/build_git_config.hpp


Subsequent configure runs:
checking for src/common/build_git_config.hpp... yes

Final build from `support/packaging/centos/` installed and ran agent;
  mesos.x86_64 0:1.8.0-0.1.pre.20190226gitc125541.el7

[root@9b0d899ff4c6 ~]# mesos-slave --work_dir=/tmp --master=
I0226 01:00:48.581748   157 main.cpp:350] Build: 2019-02-26 00:36:49 by centos
I0226 01:00:48.581817   157 main.cpp:351] Version: 1.8.0
I0226 01:00:48.581823   157 main.cpp:358] Git SHA: c125541b8e4f2c2f6f56fe7e1c2e0b26d5bbfc62
I0226 01:00:48.587003   157 systemd.cpp:240] systemd version `219` detected
I0226 01:00:48.587026   157 main.cpp:453] Initializing systemd state


Till Toenshoff

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message