-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70053/#review213192
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70046, 70053]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh
- Mesos Reviewbot
On Feb. 25, 2019, 9:20 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70053/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2019, 9:20 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a non-functional change to avoid manual memory management. By
> using a `std::string` instead of an explicitly heap-allocated buffer the
> used pattern might even avoid hitting the heap altogether due to the SSO
> but this function might be runtime bounded by I/O anyway.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/mktemp.hpp 8dab2599f13c3e1dab109423c8a938ec16540aaf
>
>
> Diff: https://reviews.apache.org/r/70053/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
|