mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70040: Added test for terminal operation updates after master failover.
Date Mon, 25 Feb 2019 22:56:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70040/#review213190
-----------------------------------------------------------



Patch looks great!

Reviews applied: [69968, 69960, 69961, 69962, 69963, 69967, 69980, 70014, 69872, 69869, 70040]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Feb. 25, 2019, 9 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70040/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2019, 9 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9542
>     https://issues.apache.org/jira/browse/MESOS-9542
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test covers a corner case where an agent reregisters with the
> master with a pending operation, but the operation's originating
> framework is unknown.  This can occur in a variety of situations like:
>   * the master fails over and a framework never reregisters,
>   * a completed framework is rotated out of the master's memory with
>     pending operations, or
>   * an agent with pending operations is migrated from one cluster to
>     another.
> 
> In this case, the master should "adopt" the orphan operation only
> after a delay.  This gives the framework some time to reregister.
> But if the framework does not reregister in time, the master will
> be in charge of acknowledging operation status updates.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp a661951a0a326cc342aa0c45dd0967692ae70941

> 
> 
> Diff: https://reviews.apache.org/r/70040/diff/2/
> 
> 
> Testing
> -------
> 
> ```
> make check
> src/mesos-tests --gtest_filter="*TerminalOrphanOperationAfterMasterFailover*" --verbose
> src/mesos-tests --gtest_filter="*Operation*" --verbose
> ```
> 
> (Internal CI run pending)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message