mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 70053: Used std::string as buffer instead of manually managed dynamic array.
Date Mon, 25 Feb 2019 21:20:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70053/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

This is a non-functional change to avoid manual memory management. By
using a `std::string` instead of an explicitly heap-allocated buffer the
used pattern might even avoid hitting the heap altogether due to the SSO
but this function might be runtime bounded by I/O anyway.


Diffs
-----

  3rdparty/stout/include/stout/os/posix/mktemp.hpp 8dab2599f13c3e1dab109423c8a938ec16540aaf



Diff: https://reviews.apache.org/r/70053/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message