mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Re: Review Request 70046: Prevented closing invalid file descriptors.
Date Mon, 25 Feb 2019 21:19:25 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 25, 2019, 10:19 p.m.)

Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao.


Simplify code more as suggested by Ben

Repository: mesos


During the refactoring of `d838f2958e` we reorganized the code flow to
propagate failures from `os::close` and introduce code which migh
close an invalid file descriptor. While this would produce an `Error`
result from `mktemp` in any case, it would have lead to confusing
error messages in that scenario. This patch prevents closing invalid
file descriptors altogether which is consistent with the
pre-refactoring behavior.

Diffs (updated)

  3rdparty/stout/include/stout/os/posix/mktemp.hpp 8dab2599f13c3e1dab109423c8a938ec16540aaf




`make check`


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message