mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 69869: Added test for tearing down frameworks while creating disks.
Date Mon, 25 Feb 2019 20:27:16 GMT


> On Feb. 25, 2019, 10:59 a.m., Greg Mann wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 5130 (patched)
> > <https://reviews.apache.org/r/69869/diff/3/?file=2126214#file2126214line5130>
> >
> >     LAUNCH_GROUP isn't a non-speculative operation; it uses `addTask()` while processing
the operation in the master, which updates the agent's used resources under the assumption
that the task launches will succeed: https://github.com/apache/mesos/blob/68b73928a622be093a720277ec2ae1589c221b88/src/master/master.cpp#L12615

I grabbed the definition of non-speculative from this helper:
https://github.com/apache/mesos/blob/68b73928a622be093a720277ec2ae1589c221b88/src/common/protobuf_utils.cpp#L891-L894


> On Feb. 25, 2019, 10:59 a.m., Greg Mann wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 5243-5246 (patched)
> > <https://reviews.apache.org/r/69869/diff/3/?file=2126214#file2126214line5243>
> >
> >     Should we do this before the call to `mesos.send()`?

We need the clock unpaused for the SLRP's initialization, but it is safe to pause the clock
afterwards.  I guess it wouldn't hurt to move up the pausing as much as possible.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69869/#review213179
-----------------------------------------------------------


On Feb. 21, 2019, 4:08 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69869/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2019, 4:08 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9542
>     https://issues.apache.org/jira/browse/MESOS-9542
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The CREATE_DISK and DESTROY_DISK operations are "non-speculative"
> operations, which means the master must wait for the operations to
> complete successfully before the master can update its resources.
> Because the master must wait to update the results of non-speculative
> operations, it is possible for the framework making the
> CREATE/DESTROY_DISK to be torn down before the operation completes.
> 
> This commit adds a test to make sure the master can gracefully handle
> such a case.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp a661951a0a326cc342aa0c45dd0967692ae70941

> 
> 
> Diff: https://reviews.apache.org/r/69869/diff/3/
> 
> 
> Testing
> -------
> 
> src/mesos-tests --gtest_filter="StorageLocalResourceProviderTest.FrameworkTeardownBeforeTerminalOperationStatusUpdate"
--verbose
> 
> One more test added next patch.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message