mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69676: Implemented recovery for volume gid manager.
Date Mon, 25 Feb 2019 14:15:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69676/#review213166
-----------------------------------------------------------



How is this patch related to https://reviews.apache.org/r/69543/? Some issues were raised
over there and a discussion started. We should strongly avoid loosing such context as it makes
it harder to understand patches later.

- Benjamin Bannier


On Jan. 7, 2019, 2:15 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69676/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2019, 2:15 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-8767
>     https://issues.apache.org/jira/browse/MESOS-8767
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented recovery for volume gid manager.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt bde070445b644e15d46c390d1c983caabaa1fec8 
>   src/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa 
>   src/slave/slave.hpp 2eadf5fce9a314f1ec0ac5d51820c6381f5f1468 
>   src/slave/slave.cpp ad3b693a716cf6103345a157bf28dd60a7b07d32 
>   src/slave/volume_gid_manager/state.hpp PRE-CREATION 
>   src/slave/volume_gid_manager/state.proto PRE-CREATION 
>   src/slave/volume_gid_manager/volume_gid_manager.hpp PRE-CREATION 
>   src/slave/volume_gid_manager/volume_gid_manager.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69676/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message