mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Review Request 70047: Updated build specific artefact generation.
Date Mon, 25 Feb 2019 01:32:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70047/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Joseph Wu.


Bugs: MESOS-9605
    https://issues.apache.org/jira/browse/MESOS-9605


Repository: mesos


Description
-------

For autotools, we extracted additional build info like the git branch
and sha during the automake phase handing them into libbuild via
commandline defines.

CMake builds however used a configuration file for this purpose.

This patch updates both build systems to make use of
build_config.hpp.in for build specific configuration artefacts.


Diffs
-----

  cmake/CompilationConfigure.cmake c330324e2e3dea6e71980ae8c9ed71632ebb018e 
  configure.ac ee29fc784e53ebaf1bb016c33136b200c646ee9b 
  src/Makefile.am 283d5ed89b36d74da36f38c26aec03c6129d6261 
  src/common/build.cpp f5271d87d33ac429fb94093a347be1d6c25d3432 
  src/common/build_config.hpp.in 4cce2403c1d7a5feee8fd2fffa7cf4308507cd0c 


Diff: https://reviews.apache.org/r/70047/diff/1/


Testing
-------

manually tested both cmake and autotools.


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message