mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70044: Moved status update streams of operations on agent's default resources.
Date Sat, 23 Feb 2019 15:10:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70044/#review213119
-----------------------------------------------------------



Patch looks great!

Reviews applied: [69977, 69978, 70044]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Feb. 23, 2019, 1:34 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70044/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2019, 1:34 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
> 
> 
> Bugs: MESOS-9597
>     https://issues.apache.org/jira/browse/MESOS-9597
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch moves the operation status update streams for operations
> affecting agent default resources from the root of the metadata
> directory to the agent's metadata directory, i.e.,
> `meta/operations/<operation_uuid>` to
> `meta/slaves/<slave_id/operations/<operation_uuid>`.
> 
> 
> Diffs
> -----
> 
>   src/slave/paths.hpp bddaef220b4c9ac7d7988664cd82828e32f5a0df 
>   src/slave/paths.cpp 4ff9c5da05aef1496323daf269ab9b3215b0b31f 
>   src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02 
>   src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79 
> 
> 
> Diff: https://reviews.apache.org/r/70044/diff/1/
> 
> 
> Testing
> -------
> 
> Tests still pass on GNU/Linux + quite some manual testing.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message