-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69411/#review213116
-----------------------------------------------------------
Patch looks great!
Reviews applied: [69411]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh
- Mesos Reviewbot
On Nov. 22, 2018, 1:21 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69411/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2018, 1:21 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This review adds a new method `cluster::Master::create()` that
> allows constructing masters while only specifying the non-standard
> components required for the specific test, like this:
>
> auto master = cluster::Master::build()
> .withZookeeperUrl(url)
> .withAllocator(allocator);
>
> This is sometimes better known as "fluent interface".
>
>
> Diffs
> -----
>
> src/tests/cluster.hpp ad2b80e658d2f8afcefe9969d62cd33f0c475ce9
> src/tests/cluster.cpp 2b351ca70d8e80008e49722aa7d46918b5ecd9b0
>
>
> Diff: https://reviews.apache.org/r/69411/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
|