mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 69551: Renamed `Metrics()` function in test utils.
Date Fri, 22 Feb 2019 22:53:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69551/#review213099
-----------------------------------------------------------



Bad review!

Reviews applied: [69551]

Error:
2019-02-22 22:53:41 URL:https://reviews.apache.org/r/69551/diff/raw/ [52606/52606] -> "69551.patch"
[1]
error: patch failed: src/tests/master_quota_tests.cpp:520
error: src/tests/master_quota_tests.cpp: patch does not apply
error: patch failed: src/tests/partition_tests.cpp:3094
error: src/tests/partition_tests.cpp: patch does not apply
error: patch failed: src/tests/resource_provider_manager_tests.cpp:1476
error: src/tests/resource_provider_manager_tests.cpp: patch does not apply
error: patch failed: src/tests/storage_local_resource_provider_tests.cpp:3286
error: src/tests/storage_local_resource_provider_tests.cpp: patch does not apply

- Mesos Reviewbot


On Dec. 13, 2018, 6:23 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69551/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2018, 6:23 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed `mesos::internal::tests::Metrics` to
> `mesos::internal::tests::getMetricsSnapshot` to conform to our style
> guide, and make it more clear to the reader that code like
> 
>     auto metrics = Metrics()
> 
> is indeed a function call and not an instantiation of a class
> called `Metrics`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 250ead9a9852a0ceb52aaa7e20ef386866ad6ecf

>   src/tests/containerizer/mesos_containerizer_tests.cpp 449928c10b897061642af8ad267f8b70695940e6

>   src/tests/containerizer/port_mapping_tests.cpp 9c297b81bd8b997869d33c8fcb9e9367a0457cdc

>   src/tests/containerizer/xfs_quota_tests.cpp 96cd40d2fa05664571b04ffe08482c584d2935ba

>   src/tests/fetcher_cache_tests.cpp 8766ffe25a22eaaa9c87ccd8f169ed3a15438141 
>   src/tests/fetcher_tests.cpp 90bee40f80d8524d289599ede10e09262458c62d 
>   src/tests/gc_tests.cpp a583f1d79a9dd9def24ccfeb9e49ea0392173420 
>   src/tests/hierarchical_allocator_tests.cpp a3a6d7bb956a6d16f01e2c312d69f704fcbe9ddd

>   src/tests/log_tests.cpp a8980e3676f51d14087f56338ff45de2927ea992 
>   src/tests/master_authorization_tests.cpp f65b6210a8189ec5e9089bce845a46d325253058 
>   src/tests/master_quota_tests.cpp 354a9e988c3e4cdf94c99170d2abb7cb17f9e11a 
>   src/tests/master_slave_reconciliation_tests.cpp de6e382ed16d8c02d90dd6157ded1aaae9b593aa

>   src/tests/master_tests.cpp 3bff7a13bb8013ef91b72c14ace23ee94bc190e9 
>   src/tests/oversubscription_tests.cpp edb95867ce7f0a8f3ab0eb854561dbfcf22280e3 
>   src/tests/partition_tests.cpp 15af47b7d4328861a7523e669c2afc6a6574166b 
>   src/tests/persistent_volume_tests.cpp 6afc56cecbf6f06615dbc8632578332e6f7fb6ae 
>   src/tests/rate_limiting_tests.cpp 1946a6c108ce26c559158da0ee9bfed96283aba6 
>   src/tests/resource_provider_manager_tests.cpp b61c50f839b7a0f49a781a6f44aa4f10ad7ebafe

>   src/tests/scheduler_tests.cpp b571bb1d20744b943580677a26db4c12c7c311d1 
>   src/tests/slave_recovery_tests.cpp 5ee64a40093684418e0b4f9d3d6c98a4efcecf15 
>   src/tests/slave_tests.cpp 1e918712d73d0a03c4c15b41babff1f649ba9c07 
>   src/tests/storage_local_resource_provider_tests.cpp 422a1520433ed5855914be8b4cc7a5b8608068c1

>   src/tests/utils.hpp b2f22cd4db223d167aa35109cd8de6df82ed1f4d 
>   src/tests/utils.cpp 06d3d6214b0e3d8c3902191b7aeb477467300c6a 
> 
> 
> Diff: https://reviews.apache.org/r/69551/diff/2/
> 
> 
> Testing
> -------
> 
> Internal CI (5043) run only showed known flakes:
> 
> ```
> 38,720 tests,  5 failures 
> 
> Configuration Name                    Duration All Failed Skipped
> FLAG=Clang,label=mesos-ec2-ubuntu-16.04	18 min	3206	0	0
> FLAG=Plain,label=mesos-ec2-ubuntu-16.04	18 min	3206	0	0
> FLAG=CMake,label=mesos-ec2-ubuntu-16.04	19 min	3159	0	0
> FLAG=SSL,label=mac	9 min 45 sec	2701	3	0
> FLAG=SSL,label=mesos-ec2-ubuntu-16.04	18 min	3269	0	0
> FLAG=SSL,label=mesos-ec2-debian-8	20 min	3265	0	0
> FLAG=SSL,label=mesos-ec2-debian-9	20 min	3267	1	0
> FLAG=SSL,label=mesos-ec2-centos-7	20 min	3260	0	0
> FLAG=BUILD_ISOLATORS,label=mesos-ec2-ubuntu-16.04	5.4 sec	606	0	0
> FLAG=CMake,label=mesos-ec2-centos-7	22 min	3150	1	0
> FLAG=SSL,label=mesos-ec2-ubuntu-14.04	19 min	3262	0	0
> FLAG=Plain,label=mesos-ec2-centos-7	20 min	3197	0	0
> FLAG=SSL,label=mesos-ec2-centos-6	16 min	3172	0	0
> ```
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message