mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 70040: Added test for terminal operation updates after master failover.
Date Fri, 22 Feb 2019 02:59:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70040/#review213071
-----------------------------------------------------------



PASS: Mesos patch 70040 was successfully built and tested.

Reviews applied: `['69960', '69961', '69962', '69963', '69967', '69980', '70014', '69872',
'69869', '70040']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2920/mesos-review-70040

- Mesos Reviewbot Windows


On Feb. 22, 2019, 12:31 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70040/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2019, 12:31 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9542
>     https://issues.apache.org/jira/browse/MESOS-9542
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test covers a corner case where an agent reregisters with the
> master with a pending operation, but the operation's originating
> framework is unknown.  This can occur in a variety of situations like:
>   * the master fails over and a framework never reregisters,
>   * a completed framework is rotated out of the master's memory with
>     pending operations, or
>   * an agent with pending operations is migrated from one cluster to
>     another.
> 
> In this case, the master should "adopt" the orphan operation only
> after a delay.  This gives the framework some time to reregister.
> But if the framework does not reregister in time, the master will
> be in charge of acknowledging operation status updates.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp a661951a0a326cc342aa0c45dd0967692ae70941

> 
> 
> Diff: https://reviews.apache.org/r/70040/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> make check
> src/mesos-tests --gtest_filter="*TerminalOrphanOperationAfterMasterFailover*" --verbose
> src/mesos-tests --gtest_filter="*Operation*" --verbose
> ```
> 
> (Internal CI run pending)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message