mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 69869: Added test for tearing down frameworks while creating disks.
Date Fri, 22 Feb 2019 00:08:55 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 21, 2019, 4:08 p.m.)

Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.


Fix mock expectation (almost always occurs) when scheduler tries to reconnect to master during
scheduler teardown.

Summary (updated)

Added test for tearing down frameworks while creating disks.

Bugs: MESOS-9542

Repository: mesos


The CREATE_DISK and DESTROY_DISK operations are "non-speculative"
operations, which means the master must wait for the operations to
complete successfully before the master can update its resources.
Because the master must wait to update the results of non-speculative
operations, it is possible for the framework making the
CREATE/DESTROY_DISK to be torn down before the operation completes.

This commit adds a test to make sure the master can gracefully handle
such a case.

Diffs (updated)

  src/tests/storage_local_resource_provider_tests.cpp a661951a0a326cc342aa0c45dd0967692ae70941




The test currently fails with the exact message as MESOS-9542, which is the intended behavior
right now (we are discussing the fix).

src/mesos-tests --gtest_filter="StorageLocalResourceProviderTest.FrameworkTeardownBeforeTerminalOperationStatusUpdate"


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message