mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 69872: Accounted for possible lack of OperationID in RP responses.
Date Fri, 22 Feb 2019 00:08:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69872/
-----------------------------------------------------------

(Updated Feb. 21, 2019, 4:08 p.m.)


Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.


Changes
-------

Added this to the chain of orphan operation patches.  Mostly related to tests.


Bugs: MESOS-9542
    https://issues.apache.org/jira/browse/MESOS-9542


Repository: mesos


Description
-------

Operations sent to a resource provider may include an OperationID
in addition to an Operation UUID.  The UUID is sufficient to uniquely
identify the operation, so it is possible for the resource provider
to omit the OperationID in its responses to the agent.

This commit lets the agent fill in any missing ID before updates
are acted upon, such as being sent to the master.


Diffs
-----

  src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79 


Diff: https://reviews.apache.org/r/69872/diff/2/


Testing (updated)
-------

Ran the test here (https://reviews.apache.org/r/69869/diff/1) to get past line 11692.

That test is rewritten in the subsequent diff though.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message