mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 70014: Removed operations when removing resource providers.
Date Fri, 22 Feb 2019 00:07:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70014/
-----------------------------------------------------------

(Updated Feb. 21, 2019, 4:07 p.m.)


Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.


Changes
-------

With the change here: https://reviews.apache.org/r/69962/diff/2-3/ this patch can use `Master::removeOperation`
correctly here.


Bugs: MESOS-9542
    https://issues.apache.org/jira/browse/MESOS-9542


Repository: mesos


Description
-------

When a resource provider explicitly disconnects from the agent, the
agent will send a `UpdateSlaveMessage` to the master, telling the
master to remove the resource provider.  If there are any operations
associated with the resource provider, they must be removed too,
because there is no way to make forward progress on resource provider
operations without a resource provider.

This removes a potential memory leak in the master's Framework structs.


Diffs (updated)
-----

  src/master/master.cpp 106d924bf16231b3bda3fb719db68c01d73644ee 


Diff: https://reviews.apache.org/r/70014/diff/2/

Changes: https://reviews.apache.org/r/70014/diff/1-2/


Testing
-------

Fixes a couple of (flaky) issues with `OperationReconciliationTest.AgentPendingOperationAfterMasterFailover`
when combined with the rest of the orphan operation chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message