mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 69980: Modified when master responds to operation status updates.
Date Fri, 22 Feb 2019 00:07:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69980/
-----------------------------------------------------------

(Updated Feb. 21, 2019, 4:07 p.m.)


Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.


Changes
-------

Fixed the conditional telling the master to adopt orphan operations of unknown frameworks,
with operation IDs.


Bugs: MESOS-9542
    https://issues.apache.org/jira/browse/MESOS-9542


Repository: mesos


Description
-------

When dealing with orphaned operation status updates, there are two
cases the master must deal with:
- The simple case is when the master knows the framework is completed.
  These status updates can be acknowledged by the master.
- However, a completed framework can be rotated out of the master's
  memory.  In addition, after master failover, if an agent reregisters
  before the framework, an operation can appear to be orphaned until
  the framework reregisters.

This adds a fixed delay between agent reregistration and when the
master acknowledges operation status updates from unknown frameworks.
The delay should give frameworks ample time to reregister.

The delay is based on agent reregistration in order to mitigate the
delay of acknowledging status updates of frameworks rotated out of
the completed frameworks buffer.


Diffs (updated)
-----

  src/master/constants.hpp b0ab9187b8c672180e2ffb8b63cb7349dbe43ac4 
  src/master/master.cpp 106d924bf16231b3bda3fb719db68c01d73644ee 


Diff: https://reviews.apache.org/r/69980/diff/3/

Changes: https://reviews.apache.org/r/69980/diff/2-3/


Testing (updated)
-------

See last patch in chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message