mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 69962: Added cleanup logic for orphaned operations.
Date Fri, 22 Feb 2019 00:06:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69962/
-----------------------------------------------------------

(Updated Feb. 21, 2019, 4:06 p.m.)


Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.


Changes
-------

* Modified `Master::removeOperation` to not recover resources from orphaned operations (per
https://reviews.apache.org/r/70014/#comment298857 ).
* Clarified a comment.


Bugs: MESOS-9542
    https://issues.apache.org/jira/browse/MESOS-9542


Repository: mesos


Description (updated)
-------

The resources used by orphaned operations are not accounted for
in the Slave struct's `usedResources`, and must be treated differently
when cleaning up the operation.  Removal of non-terminal orphan
operations will instead augment the `totalResources`.

NOTE: The only codepath that can remove non-terminal operations is
when removing the agent or a resource provider.  In this case, 
there is no need to update the allocator with the augmented 
`totalResources` because the removal codepaths will already
update the allocator.


Diffs (updated)
-----

  src/master/master.cpp 106d924bf16231b3bda3fb719db68c01d73644ee 


Diff: https://reviews.apache.org/r/69962/diff/3/

Changes: https://reviews.apache.org/r/69962/diff/2-3/


Testing
-------

See last patch in chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message