mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 69960: Added the concept of "orphaned operations" to the master.
Date Fri, 22 Feb 2019 00:06:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69960/
-----------------------------------------------------------

(Updated Feb. 21, 2019, 4:06 p.m.)


Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.


Changes
-------

* Reworded/reworked some comments based on various changes made to the chain over the last
few revisions.
* When removing a framework, terminal operations are also marked as orphans now.
* Added a critical section to the allocator when removing a framework and its operations.
* Added a log message when orphaning an operation.


Bugs: MESOS-9542
    https://issues.apache.org/jira/browse/MESOS-9542


Repository: mesos


Description (updated)
-------

An orphaned operation is a non-speculative operation whose
originating framework is unknown.  These operations will consume
resources until they are terminated, but will have no entry
in the allocator because their associated framework does not exist.

To account for resources used by orphaned operations, the operation's
resources are removed from the agent's total resources upon being
orphaned.

This commit handles one of the two possible code paths which can
introduce orphaned operations.


Diffs (updated)
-----

  src/master/master.hpp ccd117f607747d49e5259d9ba6645fed61811adf 
  src/master/master.cpp 106d924bf16231b3bda3fb719db68c01d73644ee 


Diff: https://reviews.apache.org/r/69960/diff/4/

Changes: https://reviews.apache.org/r/69960/diff/3-4/


Testing
-------

See last patch in chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message