mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Lai <ja...@jasonlai.net>
Subject Re: Review Request 69287: Added test cases for the `volume/host_path` isolator.
Date Thu, 21 Feb 2019 23:35:36 GMT


> On Feb. 21, 2019, 8:08 p.m., Gilbert Song wrote:
> > src/tests/containerizer/volume_host_path_isolator_tests.cpp
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/69287/diff/1/?file=2106294#file2106294line30>
> >
> >     newline above

Done.


> On Feb. 21, 2019, 8:08 p.m., Gilbert Song wrote:
> > src/tests/containerizer/volume_host_path_isolator_tests.cpp
> > Lines 51 (patched)
> > <https://reviews.apache.org/r/69287/diff/1/?file=2106294#file2106294line51>
> >
> >     ditto

Done.


- Jason


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69287/#review213047
-----------------------------------------------------------


On Nov. 7, 2018, 10:06 p.m., Jason Lai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69287/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2018, 10:06 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, and James
Peach.
> 
> 
> Bugs: MESOS-9009
>     https://issues.apache.org/jira/browse/MESOS-9009
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test cases for the `volume/host_path` isolator for whitelisted
> non-existing host paths.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/volume_host_path_isolator_tests.cpp 81bf72e869d36edb162b121f9e84a53d2096dae3

> 
> 
> Diff: https://reviews.apache.org/r/69287/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Jason Lai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message