mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 68919: Removed unbundling by default for libevent on macOS when using CMake.
Date Thu, 21 Feb 2019 21:46:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68919/#review213053
-----------------------------------------------------------



Bad review!

Reviews applied: [68919]

Error:
2019-02-21 21:46:07 URL:https://reviews.apache.org/r/68919/diff/raw/ [725/725] -> "68919.patch"
[1]
error: patch failed: cmake/CompilationConfigure.cmake:80
error: cmake/CompilationConfigure.cmake: patch does not apply

- Mesos Reviewbot


On Oct. 3, 2018, 8:55 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68919/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2018, 8:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unbundling by default for libevent on macOS when using CMake.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake a820c867b41d2120525c5a32128812ae527ffeba 
> 
> 
> Diff: https://reviews.apache.org/r/68919/diff/1/
> 
> 
> Testing
> -------
> 
> macos: cmake .. -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON  -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
-DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja && ninja check -j12
> macos: cmake .. -DUNBUNDLED_LIBEVENT=ON -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
-DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja && ninja check -j12
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message