mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 70034: Consistently used `override` in tests' `BlockingAuthorizer`.
Date Thu, 21 Feb 2019 13:48:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70034/#review213027
-----------------------------------------------------------


Ship it!




I was about to propose adding this to our style guide AS WELL, but then I saw that it's already
in there!

- Benno Evers


On Feb. 21, 2019, 11:33 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70034/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2019, 11:33 a.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Consistently used `override` in tests' `BlockingAuthorizer`.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_load_tests.cpp 4e9c8e89d50a7a93f3e25b7120f4d2ec4e44a0c8 
> 
> 
> Diff: https://reviews.apache.org/r/70034/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message