mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70022: Added master load tests to cmake build.
Date Thu, 21 Feb 2019 11:33:58 GMT


> On Feb. 20, 2019, 4:17 p.m., Benjamin Bannier wrote:
> > LGTM. We should also run `support/mesos-tidy.sh`. That setup depends on cmake and
we could see new failures from adding the file there. I kicked off a run.
> 
> Benjamin Bannier wrote:
>     Our tidy checks report something here,
>     ```
>     /tmp/SRC/src/tests/master_load_tests.cpp:181:3: warning: annotate this function with
'override' or (rarely) 'final' [modernize-use-override]
>       ~BlockingAuthorizer()
>       ^
>                             override
>     ```
>     
>     We should fix this close to this patch.

https://reviews.apache.org/r/70034/


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70022/#review212961
-----------------------------------------------------------


On Feb. 20, 2019, 4:06 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70022/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2019, 4:06 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds `master_load_tests.cpp` to the cmake build
> system.
> 
> 
> Diffs
> -----
> 
>   src/tests/CMakeLists.txt b647d5b2b2273e0ba77accf2b213dc07ce34f399 
> 
> 
> Diff: https://reviews.apache.org/r/70022/diff/1/
> 
> 
> Testing
> -------
> 
> CI run still in progress.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message