mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 70014: Removed operations when removing resource providers.
Date Thu, 21 Feb 2019 01:09:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70014/#review213003
-----------------------------------------------------------




src/master/master.cpp
Lines 8372-8387 (patched)
<https://reviews.apache.org/r/70014/#comment298857>

    Do we recover the resources associated with non-terminal, non-speculative operations in
this code path? This function uses `allocator->updateSlave()` to change the agent's total
resources, but I don't think that affects the allocation. Will we end up "leaking" allocations
in the allocator here? Maybe we should just use `Master::removeOperation()`?


- Greg Mann


On Feb. 20, 2019, 1:30 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70014/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2019, 1:30 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9542
>     https://issues.apache.org/jira/browse/MESOS-9542
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When a resource provider explicitly disconnects from the agent, the
> agent will send a `UpdateSlaveMessage` to the master, telling the
> master to remove the resource provider.  If there are any operations
> associated with the resource provider, they must be removed too,
> because there is no way to make forward progress on resource provider
> operations without a resource provider.
> 
> This removes a potential memory leak in the master's Framework structs.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 106d924bf16231b3bda3fb719db68c01d73644ee 
> 
> 
> Diff: https://reviews.apache.org/r/70014/diff/1/
> 
> 
> Testing
> -------
> 
> Fixes a couple of (flaky) issues with `OperationReconciliationTest.AgentPendingOperationAfterMasterFailover`
when combined with the rest of the orphan operation chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message