mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James DeFelice <james.defel...@gmail.com>
Subject Re: Review Request 70024: Failed the scripts if `--points-at` is not supported.
Date Wed, 20 Feb 2019 21:55:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70024/#review212987
-----------------------------------------------------------


Ship it!




Ship It!

- James DeFelice


On Feb. 20, 2019, 7:18 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70024/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2019, 7:18 p.m.)
> 
> 
> Review request for mesos and James DeFelice.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> On some Jenkins boxes, the git installed on the box does not support
> `--points-at`. Instead of silently assume the 'master' branch in the
> scripts (which could be wrong), we fail hard here.
> 
> 
> Diffs
> -----
> 
>   support/jenkins/docker-centos.sh c0612d0043aeafbc7ed325e8de513e7c4c7de1ef 
>   support/jenkins/mini.sh a012c6c35c4ae113eec541d93a8bc8005c566a75 
> 
> 
> Diff: https://reviews.apache.org/r/70024/diff/1/
> 
> 
> Testing
> -------
> 
> run the script locally.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message