mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70026: Increased the number of review requests queried by ReviewBot to 200.
Date Wed, 20 Feb 2019 21:29:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70026/#review212981
-----------------------------------------------------------


Fix it, then Ship it!





support/verify-reviews.py
Lines 364-366 (patched)
<https://reviews.apache.org/r/70026/#comment298844>

    I think moving this up to the declaration of `query_parameters` would provide more context
(e.g., that 200 is the possible max value).


- Benjamin Bannier


On Feb. 20, 2019, 10:25 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70026/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2019, 10:25 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Without the `max-results` query parameter, ReviewBoard API returns 25
> results by default.
> 
> 
> Diffs
> -----
> 
>   support/verify-reviews.py 8cccc4ffb108eee4d0ca9879687deb941724fb74 
> 
> 
> Diff: https://reviews.apache.org/r/70026/diff/1/
> 
> 
> Testing
> -------
> 
> ?  mesos git:(vinod/reviewbot_max_results) ? ./support/verify-reviews.py -u vinodkone
-p foo --skip-verify
> Checking if review: 66981 needs verification
> Skipping blocking review 66981
> Checking if review: 66983 needs verification
> Skipping blocking review 66983
> Checking if review: 65939 needs verification
> Skipping blocking review 65939
> Checking if review: 66994 needs verification
> Skipping blocking review 66994
> Checking if review: 66982 needs verification
> Skipping blocking review 66982
> Checking if review: 66984 needs verification
> Skipping blocking review 66984
> Checking if review: 66872 needs verification
> Skipping blocking review 66872
> Checking if review: 67047 needs verification
> Skipping blocking review 67047
> Checking if review: 67048 needs verification
> Skipping blocking review 67048
> Checking if review: 67049 needs verification
> Skipping blocking review 67049
> Checking if review: 66228 needs verification
> Skipping blocking review 66228
> Checking if review: 66229 needs verification
> Skipping blocking review 66229
> Checking if review: 66230 needs verification
> Latest diff timestamp: 2018-05-10 01:14:47
> Checking if review: 66990 needs verification
> Skipping blocking review 66990
> Checking if review: 67044 needs verification
> Latest diff timestamp: 2018-05-14 17:25:07
> Latest dependency change timestamp: 2018-05-09 23:51:04
> Checking if review: 66847 needs verification
> Skipping blocking review 66847
> Checking if review: 66825 needs verification
> Skipping blocking review 66825
> Checking if review: 67165 needs verification
> Skipping blocking review 67165
> Checking if review: 67166 needs verification
> Skipping blocking review 67166
> Checking if review: 67168 needs verification
> Skipping blocking review 67168
> Checking if review: 67170 needs verification
> Skipping blocking review 67170
> Checking if review: 67171 needs verification
> Skipping blocking review 67171
> Checking if review: 67172 needs verification
> Skipping blocking review 67172
> Checking if review: 67169 needs verification
> Skipping blocking review 67169
> Checking if review: 67173 needs verification
> Latest diff timestamp: 2018-05-16 22:48:58
> Checking if review: 67176 needs verification
> Skipping blocking review 67176
> Checking if review: 67226 needs verification
> Skipping blocking review 67226
> Checking if review: 67227 needs verification
> Skipping blocking review 67227
> Checking if review: 67177 needs verification
> Latest diff timestamp: 2018-05-17 01:03:43
> Checking if review: 67215 needs verification
> Latest diff timestamp: 2018-05-18 12:34:23
> Checking if review: 66871 needs verification
> Skipping blocking review 66871
> Checking if review: 67228 needs verification
> Latest diff timestamp: 2018-05-18 23:58:38
> Checking if review: 65900 needs verification
> Skipping blocking review 65900
> Checking if review: 64907 needs verification
> Skipping blocking review 64907
> Checking if review: 64908 needs verification
> Skipping blocking review 64908
> Checking if review: 61158 needs verification
> Skipping blocking review 61158
> Checking if review: 64074 needs verification
> Latest diff timestamp: 2018-01-03 07:48:54
> Latest dependency change timestamp: 2018-01-03 07:22:09
> Checking if review: 66846 needs verification
> Skipping blocking review 66846
> Checking if review: 67301 needs verification
> Latest diff timestamp: 2018-05-24 22:50:21
> Checking if review: 67304 needs verification
> Latest diff timestamp: 2018-05-25 01:11:31
> Checking if review: 67344 needs verification
> Latest diff timestamp: 2018-06-01 14:49:27
> Checking if review: 66881 needs verification
> Latest diff timestamp: 2018-06-21 00:07:01
> Latest dependency change timestamp: 2018-06-21 00:08:09
> Checking if review: 67601 needs verification
> Latest diff timestamp: 2018-06-27 02:48:40
> Checking if review: 67631 needs verification
> Latest diff timestamp: 2018-06-18 15:50:47
> Checking if review: 67761 needs verification
> Skipping blocking review 67761
> Checking if review: 67788 needs verification
> Latest diff timestamp: 2018-06-29 18:40:53
> Checking if review: 67476 needs verification
> Latest diff timestamp: 2018-06-06 13:55:11
> Checking if review: 67425 needs verification
> Latest diff timestamp: 2018-06-02 23:31:30
> Checking if review: 67825 needs verification
> Latest diff timestamp: 2018-07-04 00:50:23
> Checking if review: 66845 needs verification
> Skipping blocking review 66845
> Checking if review: 66823 needs verification
> Latest diff timestamp: 2018-05-16 00:29:15
> Latest dependency change timestamp: 2018-07-06 18:02:21
> Checking if review: 66822 needs verification
> Latest diff timestamp: 2018-06-28 22:21:12
> Latest dependency change timestamp: 2018-07-06 18:05:45
> Checking if review: 67832 needs verification
> Latest diff timestamp: 2018-07-05 09:12:10
> Checking if review: 66048 needs verification
> Latest diff timestamp: 2018-03-13 22:45:27
> Checking if review: 67882 needs verification
> Skipping blocking review 67882
> Checking if review: 67883 needs verification
> Skipping blocking review 67883
> Checking if review: 67884 needs verification
> Latest diff timestamp: 2018-07-12 19:07:46
> Checking if review: 67921 needs verification
> Latest diff timestamp: 2018-07-15 16:59:37
> Checking if review: 67968 needs verification
> Latest diff timestamp: 2018-07-18 20:45:26
> Checking if review: 67994 needs verification
> Latest diff timestamp: 2018-07-20 06:59:04
> Checking if review: 68049 needs verification
> Skipping blocking review 68049
> Checking if review: 67602 needs verification
> Latest diff timestamp: 2018-06-14 19:44:18
> Checking if review: 68033 needs verification
> Latest diff timestamp: 2018-07-24 17:25:42
> Checking if review: 68050 needs verification
> Latest diff timestamp: 2018-07-25 23:35:02
> Checking if review: 68118 needs verification
> Skipping blocking review 68118
> Checking if review: 68119 needs verification
> Skipping blocking review 68119
> Checking if review: 67444 needs verification
> Latest diff timestamp: 2018-07-31 23:54:58
> Latest dependency change timestamp: 2018-07-31 23:56:53
> Checking if review: 68187 needs verification
> Latest diff timestamp: 2018-08-03 13:04:25
> Checking if review: 68123 needs verification
> Latest diff timestamp: 2018-08-01 00:07:28
> Checking if review: 68266 needs verification
> Latest diff timestamp: 2018-08-08 23:19:13
> Checking if review: 68297 needs verification
> Skipping blocking review 68297
> Checking if review: 68374 needs verification
> Skipping blocking review 68374
> Checking if review: 68174 needs verification
> Skipping blocking review 68174
> Checking if review: 68383 needs verification
> Latest diff timestamp: 2018-08-21 21:38:56
> Checking if review: 68175 needs verification
> Latest diff timestamp: 2018-08-22 00:31:47
> Checking if review: 67960 needs verification
> Latest diff timestamp: 2018-07-18 01:07:23
> Checking if review: 68301 needs verification
> Latest diff timestamp: 2018-08-23 18:25:52
> Latest dependency change timestamp: 2018-08-16 03:13:27
> Checking if review: 68485 needs verification
> Skipping blocking review 68485
> Checking if review: 68581 needs verification
> Skipping blocking review 68581
> Checking if review: 68543 needs verification
> Latest diff timestamp: 2018-08-28 17:23:10
> Checking if review: 68582 needs verification
> Latest diff timestamp: 2018-08-30 22:30:34
> Checking if review: 68609 needs verification
> Latest diff timestamp: 2018-09-03 16:09:58
> Checking if review: 65112 needs verification
> Latest diff timestamp: 2018-01-12 01:49:15
> Checking if review: 65116 needs verification
> Latest diff timestamp: 2018-09-11 03:48:32
> Checking if review: 68736 needs verification
> Latest diff timestamp: 2018-09-17 15:39:47
> Checking if review: 68759 needs verification
> Skipping blocking review 68759
> Checking if review: 68760 needs verification
> Skipping blocking review 68760
> Checking if review: 68761 needs verification
> Latest diff timestamp: 2018-09-19 04:53:06
> Checking if review: 68807 needs verification
> Latest diff timestamp: 2018-09-22 06:54:05
> Checking if review: 68814 needs verification
> Latest diff timestamp: 2018-09-23 01:06:47
> Checking if review: 64384 needs verification
> Skipping blocking review 64384
> Checking if review: 68508 needs verification
> Latest diff timestamp: 2018-09-25 20:48:25
> Checking if review: 68903 needs verification
> Latest diff timestamp: 2018-10-03 00:07:30
> Checking if review: 68919 needs verification
> Latest diff timestamp: 2018-10-03 20:43:47
> Checking if review: 68813 needs verification
> Skipping blocking review 68813
> Checking if review: 68904 needs verification
> Skipping blocking review 68904
> Checking if review: 68905 needs verification
> Skipping blocking review 68905
> Checking if review: 68913 needs verification
> Skipping blocking review 68913
> Checking if review: 68914 needs verification
> Skipping blocking review 68914
> Checking if review: 68915 needs verification
> Skipping blocking review 68915
> Checking if review: 68916 needs verification
> Latest diff timestamp: 2018-10-03 16:40:35
> Checking if review: 68906 needs verification
> Skipping blocking review 68906
> Checking if review: 68711 needs verification
> Skipping blocking review 68711
> Checking if review: 61818 needs verification
> Latest diff timestamp: 2017-08-22 17:17:06
> Latest dependency change timestamp: 2018-10-09 15:50:09
> Checking if review: 68971 needs verification
> Skipping blocking review 68971
> Checking if review: 68090 needs verification
> Latest diff timestamp: 2018-07-27 18:53:56
> Checking if review: 68089 needs verification
> Skipping blocking review 68089
> Checking if review: 68706 needs verification
> Latest diff timestamp: 2018-10-19 23:53:43
> Checking if review: 67959 needs verification
> Skipping blocking review 67959
> Checking if review: 67958 needs verification
> Skipping blocking review 67958
> Checking if review: 67022 needs verification
> Latest diff timestamp: 2018-09-13 17:16:19
> Checking if review: 65812 needs verification
> Skipping blocking review 65812
> Checking if review: 67175 needs verification
> Skipping blocking review 67175
> Checking if review: 69288 needs verification
> Skipping blocking review 69288
> Checking if review: 69289 needs verification
> Skipping blocking review 69289
> Checking if review: 69287 needs verification
> Latest diff timestamp: 2018-11-07 21:58:32
> Checking if review: 68804 needs verification
> Skipping blocking review 68804
> Checking if review: 69325 needs verification
> Latest diff timestamp: 2018-11-13 06:27:12
> Checking if review: 69403 needs verification
> Latest diff timestamp: 2018-11-19 23:36:24
> Checking if review: 69313 needs verification
> Latest diff timestamp: 2018-11-10 23:58:11
> Checking if review: 69312 needs verification
> Skipping blocking review 69312
> Checking if review: 69311 needs verification
> Skipping blocking review 69311
> Checking if review: 69290 needs verification
> Skipping blocking review 69290
> Checking if review: 69423 needs verification
> Latest diff timestamp: 2018-11-22 00:14:14
> Checking if review: 67185 needs verification
> Latest diff timestamp: 2018-12-06 01:28:44
> Checking if review: 68654 needs verification
> Latest diff timestamp: 2018-12-06 01:26:21
> Checking if review: 66649 needs verification
> Latest diff timestamp: 2018-12-06 04:26:31
> Checking if review: 68785 needs verification
> Latest diff timestamp: 2018-12-06 05:56:23
> Checking if review: 69553 needs verification
> Skipping blocking review 69553
> Checking if review: 69479 needs verification
> Skipping blocking review 69479
> Checking if review: 68162 needs verification
> Skipping blocking review 68162
> Checking if review: 69551 needs verification
> Latest diff timestamp: 2018-12-13 14:20:34
> Checking if review: 69579 needs verification
> Skipping blocking review 69579
> Checking if review: 69559 needs verification
> Latest diff timestamp: 2018-12-17 15:53:02
> Latest review timestamp: 2018-12-14 20:04:30
> Checking if review: 69411 needs verification
> Latest diff timestamp: 2018-11-22 01:12:22
> Latest dependency change timestamp: 2018-12-18 18:43:36
> Checking if review: 69547 needs verification
> Skipping blocking review 69547
> Checking if review: 69614 needs verification
> Latest diff timestamp: 2018-12-21 00:56:23
> Checking if review: 68163 needs verification
> Skipping blocking review 68163
> Checking if review: 69675 needs verification
> Skipping blocking review 69675
> Checking if review: 69544 needs verification
> Skipping blocking review 69544
> Checking if review: 69481 needs verification
> Skipping blocking review 69481
> Checking if review: 67997 needs verification
> Skipping blocking review 67997
> Checking if review: 69613 needs verification
> Skipping blocking review 69613
> Checking if review: 69676 needs verification
> Skipping blocking review 69676
> Checking if review: 69701 needs verification
> Latest diff timestamp: 2019-01-09 15:46:20
> Checking if review: 69582 needs verification
> Latest diff timestamp: 2018-12-18 08:54:00
> Checking if review: 69581 needs verification
> Skipping blocking review 69581
> Checking if review: 69694 needs verification
> Latest diff timestamp: 2019-01-10 03:51:45
> Checking if review: 69750 needs verification
> Skipping blocking review 69750
> Checking if review: 69751 needs verification
> Skipping blocking review 69751
> Checking if review: 69752 needs verification
> Skipping blocking review 69752
> Checking if review: 69753 needs verification
> Skipping blocking review 69753
> Checking if review: 69754 needs verification
> Skipping blocking review 69754
> Checking if review: 69755 needs verification
> Latest diff timestamp: 2019-01-15 19:59:16
> Checking if review: 69735 needs verification
> Latest diff timestamp: 2019-01-14 03:26:09
> Checking if review: 69775 needs verification
> Latest diff timestamp: 2019-01-16 23:07:29
> Latest review timestamp: 2019-01-16 21:39:39
> Checking if review: 69588 needs verification
> Latest diff timestamp: 2018-12-19 23:16:20
> Checking if review: 69345 needs verification
> Skipping blocking review 69345
> Checking if review: 69478 needs verification
> Skipping blocking review 69478
> Checking if review: 69869 needs verification
> Latest diff timestamp: 2019-02-06 01:18:22
> Latest dependency change timestamp: 2019-02-06 01:20:37
> Checking if review: 69286 needs verification
> Skipping blocking review 69286
> Checking if review: 69931 needs verification
> Latest diff timestamp: 2019-02-08 17:02:28
> Checking if review: 69905 needs verification
> Skipping blocking review 69905
> Checking if review: 69954 needs verification
> Skipping blocking review 69954
> Checking if review: 69872 needs verification
> Skipping blocking review 69872
> Checking if review: 69970 needs verification
> Skipping blocking review 69970
> Checking if review: 69955 needs verification
> Latest diff timestamp: 2019-02-12 05:27:22
> Checking if review: 69971 needs verification
> Latest diff timestamp: 2019-02-13 05:53:54
> Checking if review: 69342 needs verification
> Skipping blocking review 69342
> Checking if review: 69895 needs verification
> Skipping blocking review 69895
> Checking if review: 69896 needs verification
> Skipping blocking review 69896
> Checking if review: 69897 needs verification
> Skipping blocking review 69897
> Checking if review: 69904 needs verification
> Skipping blocking review 69904
> Checking if review: 69962 needs verification
> Skipping blocking review 69962
> Checking if review: 69963 needs verification
> Skipping blocking review 69963
> Checking if review: 69961 needs verification
> Skipping blocking review 69961
> Checking if review: 69977 needs verification
> Skipping blocking review 69977
> Checking if review: 66644 needs verification
> Latest diff timestamp: 2018-05-02 04:46:38
> Checking if review: 69978 needs verification
> Latest diff timestamp: 2019-02-13 23:15:36
> Checking if review: 69898 needs verification
> Skipping blocking review 69898
> Checking if review: 70009 needs verification
> Skipping blocking review 70009
> Checking if review: 69615 needs verification
> Latest diff timestamp: 2019-02-08 06:44:52
> Checking if review: 70002 needs verification
> Latest diff timestamp: 2019-02-18 09:40:13
> Checking if review: 69960 needs verification
> Skipping blocking review 69960
> Checking if review: 69967 needs verification
> Skipping blocking review 69967
> Checking if review: 69980 needs verification
> Skipping blocking review 69980
> Checking if review: 70001 needs verification
> Latest diff timestamp: 2019-02-18 08:11:33
> Checking if review: 70017 needs verification
> Skipping blocking review 70017
> Checking if review: 70014 needs verification
> Latest diff timestamp: 2019-02-20 00:44:33
> Checking if review: 70018 needs verification
> Latest diff timestamp: 2019-02-20 06:20:03
> Checking if review: 69972 needs verification
> Skipping blocking review 69972
> Checking if review: 69994 needs verification
> Skipping blocking review 69994
> Checking if review: 70010 needs verification
> Skipping blocking review 70010
> Checking if review: 70022 needs verification
> Latest diff timestamp: 2019-02-20 15:00:11
> Checking if review: 70011 needs verification
> Latest diff timestamp: 2019-02-20 15:48:45
> Checking if review: 70024 needs verification
> Skipping blocking review 70024
> Checking if review: 70023 needs verification
> Latest diff timestamp: 2019-02-20 16:51:07
> Checking if review: 70025 needs verification
> Latest diff timestamp: 2019-02-20 19:18:29
> Checking if review: 70016 needs verification
> Skipping blocking review 70016
> Checking if review: 67762 needs verification
> Latest diff timestamp: 2019-02-20 18:45:42
> 89 review requests need verification
> 66230
> 67044
> 67173
> 67177
> 67215
> 67228
> 64074
> 67301
> 67304
> 67344
> 66881
> 67601
> 67631
> 67788
> 67476
> 67425
> 67825
> 66823
> 66822
> 67832
> 66048
> 67884
> 67921
> 67968
> 67994
> 67602
> 68033
> 68050
> 67444
> 68187
> 68123
> 68266
> 68383
> 68175
> 67960
> 68301
> 68543
> 68582
> 68609
> 65112
> 65116
> 68736
> 68761
> 68807
> 68814
> 68508
> 68903
> 68919
> 68916
> 61818
> 68090
> 68706
> 67022
> 69287
> 69325
> 69403
> 69313
> 69423
> 67185
> 68654
> 66649
> 68785
> 69551
> 69559
> 69411
> 69614
> 69701
> 69582
> 69694
> 69755
> 69735
> 69775
> 69588
> 69869
> 69931
> 69955
> 69971
> 66644
> 69978
> 69615
> 70002
> 70001
> 70014
> 70018
> 70022
> 70011
> 70023
> 70025
> 67762
> 8effbf42ce2e7305973c7da5cf96760eed9da3d1
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message