mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69960: Added the concept of "orphaned operations" to the master.
Date Wed, 20 Feb 2019 21:22:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69960/#review212972
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.hpp
Lines 156 (patched)
<https://reviews.apache.org/r/69960/#comment298840>

    s/Marks a non-terminal, non-speculative/Marks a non-speculative/



src/master/master.hpp
Lines 257 (patched)
<https://reviews.apache.org/r/69960/#comment298841>

    Suggestion:
    
    s/Pending operations whose originating framework is unknown./Operations whose originating
framework is unknown. These operations could be pending, or terminal with unacknowledged status
updates./


- Greg Mann


On Feb. 20, 2019, 12:45 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69960/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2019, 12:45 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9542
>     https://issues.apache.org/jira/browse/MESOS-9542
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> An orphaned operation is a non-terminal, non-speculative operation whose
> originating framework has been torn down.  These operations will
> consume resources until they are terminated, but will have no entry
> in the allocator because their associated framework no longer exists.
> 
> To account for resources used by orphaned operations, the operation's
> resources are removed from the agent's total resources upon being
> orphaned.
> 
> This commit handles one of the two possible code paths which can
> introduce orphaned operations.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp ccd117f607747d49e5259d9ba6645fed61811adf 
>   src/master/master.cpp 106d924bf16231b3bda3fb719db68c01d73644ee 
> 
> 
> Diff: https://reviews.apache.org/r/69960/diff/3/
> 
> 
> Testing
> -------
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message