mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70014: Removed operations when removing resource providers.
Date Wed, 20 Feb 2019 08:38:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70014/#review212949
-----------------------------------------------------------



Patch looks great!

Reviews applied: [69968, 69960, 69961, 69962, 69963, 69967, 69980, 70014]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Feb. 20, 2019, 9:30 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70014/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2019, 9:30 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9542
>     https://issues.apache.org/jira/browse/MESOS-9542
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When a resource provider explicitly disconnects from the agent, the
> agent will send a `UpdateSlaveMessage` to the master, telling the
> master to remove the resource provider.  If there are any operations
> associated with the resource provider, they must be removed too,
> because there is no way to make forward progress on resource provider
> operations without a resource provider.
> 
> This removes a potential memory leak in the master's Framework structs.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 106d924bf16231b3bda3fb719db68c01d73644ee 
> 
> 
> Diff: https://reviews.apache.org/r/70014/diff/1/
> 
> 
> Testing
> -------
> 
> Fixes a couple of (flaky) issues with `OperationReconciliationTest.AgentPendingOperationAfterMasterFailover`
when combined with the rest of the orphan operation chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message