mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 70016: Supported nvidia-docker 2.0 for CUDA 10+.
Date Wed, 20 Feb 2019 06:34:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70016/#review212943
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/gpu/isolator.cpp
Lines 418 (patched)
<https://reviews.apache.org/r/70016/#comment298818>

    Ideally, for PATH and LD_LIBRARY_PATH, we don't overwrite but append. Imagine a docker
container that already defines LD_LIBRARY_PATH by itself. Doing this will probably break the
image?
    
    Curious what's your thoughts on this.


- Jie Yu


On Feb. 20, 2019, 6:26 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70016/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2019, 6:26 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-9549
>     https://issues.apache.org/jira/browse/MESOS-9549
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> nvidia-docker 2.0, which is used by CUDA 10+, moves some of the runtime
> injection that was originally done in the image to its new nvidia
> container runtime. To adapt this change, we adjusted the binaries and
> libraries and injected the `PATH` and `LD_LIBRARY_PATH` environment
> variables in the `gpu/nvidia` isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp f39e7c3d1ccfe097116fe59b05c22fbb3f83b698

>   src/slave/containerizer/mesos/isolators/gpu/volume.hpp e71fe95234ff10c72cfaa4ad39591f70a531c383

>   src/slave/containerizer/mesos/isolators/gpu/volume.cpp 0d0d778d6a8467c1ac87286e75d47faf8243afa4

> 
> 
> Diff: https://reviews.apache.org/r/70016/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> More testing done later in chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message