mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 69960: Added the concept of "orphaned operations" to the master.
Date Wed, 20 Feb 2019 00:45:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69960/
-----------------------------------------------------------

(Updated Feb. 19, 2019, 4:45 p.m.)


Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.


Changes
-------

Allowed orphan operations to be added in a terminal state.  This happens mainly when an operation
is unacknowledged, but complete.
The rest of the chain already handles this case because the transition from non-terminal to
terminal was allowed as an orphan.


Bugs: MESOS-9542
    https://issues.apache.org/jira/browse/MESOS-9542


Repository: mesos


Description
-------

An orphaned operation is a non-terminal, non-speculative operation whose
originating framework has been torn down.  These operations will
consume resources until they are terminated, but will have no entry
in the allocator because their associated framework no longer exists.

To account for resources used by orphaned operations, the operation's
resources are removed from the agent's total resources upon being
orphaned.

This commit handles one of the two possible code paths which can
introduce orphaned operations.


Diffs (updated)
-----

  src/master/master.hpp ccd117f607747d49e5259d9ba6645fed61811adf 
  src/master/master.cpp 106d924bf16231b3bda3fb719db68c01d73644ee 


Diff: https://reviews.apache.org/r/69960/diff/3/

Changes: https://reviews.apache.org/r/69960/diff/2-3/


Testing
-------

See last patch in chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message