mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations.
Date Mon, 18 Feb 2019 17:14:38 GMT


> On Feb. 12, 2019, 4:10 p.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Line 818 (original), 817 (patched)
> > <https://reviews.apache.org/r/69898/diff/2/?file=2124911#file2124911line838>
> >
> >     Is this needed?
> 
> Chun-Hung Hsiao wrote:
>     I believe so as there's no clock manipulation in this test and we use a very small
allocation interval. Am I making a mistake?

The way the test is written the framework should never be offered the same resources twice,
so whatever you set here has no effect on the test.

While it doesn't actively hurt, I feel it distracts a little from the meat of the test.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69898/#review212743
-----------------------------------------------------------


On Feb. 13, 2019, 10:24 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69898/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2019, 10:24 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9565
>     https://issues.apache.org/jira/browse/MESOS-9565
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch extends the code coverage of the `CreateDestroyDisk` and
> `CreateDestroyDiskRecovery` tests by testing pipelined `RESERVE`,
> `CREATE`, `DESTROY` and `UNRESERVE` operations along with `CREATE_DISK`
> and `DESTROY_DISK`. It also renames `CreateDestroyDiskRecovery` to
> `CreateDestroyDiskWithRecovery` for consistency.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a

> 
> 
> Diff: https://reviews.apache.org/r/69898/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Run in repetition
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message